Date: Mon, 17 May 2010 08:38:14 -0700 From: Neel Natu <neelnatu@gmail.com> To: "C. Jayachandran" <c.jayachandran@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Minor fixup for the MIPS SMP platform code. Message-ID: <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com> In-Reply-To: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com> References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi JC,
Your patch looks good. Thanks for cleaning up the platform-specific
code from mp_machdep.c.
There are a couple of style things you might want to take care of:
1. In hwfunc.h there is an extra space after the '*' in the
declaration of platform_smp_topo()
2. In platform_smp_topo() for XLR:
- Values in return statements should be enclosed in parantheses.
- space around binary operator '/'
best
Neel
On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran
<c.jayachandran@gmail.com> wrote:
> The attached patch (also at
> http://sites.google.com/site/cjayachandran/files) has two changes:
> - moves the intr masking code to platform_init_ap, so that we can avoid the
> #ifdef for XLR
> - adds a platform_smp_topo() function so that platforms can define their
> topology
>
> I've also attempted to fixup sys/mips/sibyte to reflect these changes, but
> it might need further work.
> sys/mips/cavium also might need similar changes for SMP.
>
> Please review and apply if the changes are okay.
>
> Thanks,
> JC.
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp>