Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Feb 1999 10:01:56 +0800
From:      Peter Wemm <peter@netplex.com.au>
To:        John Polstra <jdp@polstra.com>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/share/examples/svr4 README compat_sol26.tar. 
Message-ID:  <199902010201.KAA06373@spinner.netplex.com.au>
In-Reply-To: Your message of "Sun, 31 Jan 1999 12:14:08 PST." <XFMail.990131121408.jdp@polstra.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
John Polstra wrote:
> Peter Wemm wrote:
> 
> > Umm, John, we already have a precedent here..  We've got a uuencoded
> > ibcs2 'Hello world' binary.
> 
> Two wrongs don't make a right.
> 
> And it's moot anyway with respect to what I did.  The commits needed
> to be backed out for other reasons.  They were binary files, not
> uuencoded, and not checked in with "-kb".  You don't need me to
> explain the problem with that.

Good heavens, no.  What you did was 100% right.  And besides, the -kb 
support is dubious anyway, I'm not sure that it would have been handled 
correctly even if it was with -kb.  We don't need raw binary files in the 
source tree.

> > I personally feel that a statically linked 'yes, it worked' SVR4 ELF
> > binary would be useful.
> 
> I don't think it belongs in our source tree.
> 
> Look:  I took responsibility for correcting what I judged to be a
> problem in the repository that required swift remedial action.  That
> is exactly what I am expected and authorized to do, and I stand behind
> my decision and my actions.  If you feel the need to second-guess
> and/or undo my changes after the fact, well, go ahead -- you have
> seniority.

I'm sorry you took it that way.  I was commenting that we already have a
uuencoded hello.uu file and that I *personally* didn't think there was much
wrong with supplying a simple, static, uuencoded binary that would enable
testing to make sure the emulator was loaded and active.  From my personal
experience having a known working binary saved a fair amount of hassle with
ibcs2 before because it helped prove that the execution environment was ok
and that there was something wrong with the compat tree.

In any case, as you pointed out, this is not what what was imported:
$ file hello
hello: ELF 32-bit LSB executable, Intel 80386, version 1 (SVR4), dynamically linked, not stripped
This is not a static binary.. it requires the support libraries and so is 
virtually useless for testing.

Cheers,
-Peter



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199902010201.KAA06373>