Date: Tue, 13 Mar 2012 18:56:13 GMT From: Edward Sanford Sutton III <mirror176@cox.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/166055: [patch] x11/fireflies does not build with x11-toolkits/fltk installed Message-ID: <201203131856.q2DIuDS9012481@red.freebsd.org> Resent-Message-ID: <201203131900.q2DJ062e003854@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166055 >Category: ports >Synopsis: [patch] x11/fireflies does not build with x11-toolkits/fltk installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 13 19:00:05 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Edward Sanford Sutton III >Release: 8.2-STABLE >Organization: >Environment: FreeBSD darkstar.l.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Sun Dec 18 22:15:25 MST 2011 root@darkstar.l.net:/usr/obj/usr/src/sys/MYKERNEL8 amd64 >Description: I had trouble building x11/fireflies with the following output: c++ -c -O2 -pipe -fno-omit-frame-pointer -fno-strict-aliasing -I/usr/local/include -I/usr/local/include/GL -I/usr/ports/x11/fireflies/work/fireflies-2.07/libgfx/include -DHAVE_CONFIG_H -I/usr/local/include gui.cxx gui.cxx:16:32: error: FL/fl_file_chooser.H: No such file or directory gui.cxx: In member function 'bool MxGUI::snapshot_to_file(int)': gui.cxx:392: error: 'fl_file_chooser' was not declared in this scope gui.cxx: In member function 'virtual bool MxGUI::save_view_to_file()': gui.cxx:412: error: 'fl_file_chooser' was not declared in this scope gui.cxx: In member function 'virtual bool MxGUI::load_view_from_file()': gui.cxx:438: error: 'fl_file_chooser' was not declared in this scope gmake[1]: *** [gui.o] Error 1 gmake[1]: Leaving directory `/usr/ports/x11/fireflies/work/fireflies-2.07/libgfx/src' gmake: *** [libgfx/src/libgfx.a] Error 2 *** Error code 1 Stop in /usr/ports/x11/fireflies. This patch will get it to build but does not change any dependency tracking after the build is done; I do not know if final package is impacted by x11-toolkits/fltk in a way that even needs different dependencies. The makefile should likery either add it as an (optional) dependency or the port should be modified to not build against fltk if it does impact final build to have a runtime dependency. On another note, does the post extract section need more than 'xf' for flags? p is default, z is unneeded with our tar for extract, and v sounds like log bloat for all building this from the ports tree. >How-To-Repeat: Likely repeatable by installing x11-toolkits/fltk (1.3.0) before running a clean build of fireflies. >Fix: Patch attached with submission follows: --- libgfx/src/gui.cxx.orig 2012-03-13 11:02:23.469631209 -0700 +++ libgfx/src/gui.cxx 2012-03-13 11:03:19.148683872 -0700 @@ -13,7 +13,7 @@ #include <gfx/gui.h> #include <gfx/raster.h> -#include <FL/fl_file_chooser.H> +#include <FL/Fl_File_Chooser.H> #include <FL/fl_ask.H> #include <cstdio> >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203131856.q2DIuDS9012481>