Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Nov 2010 13:16:56 GMT
From:      Alessandro de Manzano <demanzano@dqmicro.it>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   usb/151862: adding support of USB GSM modem Falcom Twist
Message-ID:  <201011011316.oA1DGu0r046724@www.freebsd.org>
Resent-Message-ID: <201011011320.oA1DK9Rv059626@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         151862
>Category:       usb
>Synopsis:       adding support of USB GSM modem Falcom Twist
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 01 13:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Alessandro de Manzano
>Release:        FreeBSD 6.4-RELEASE-p10
>Organization:
>Environment:
FreeBSD bigblue.sunshine.ale 6.4-RELEASE-p10 FreeBSD 6.4-RELEASE-p10 #5: Thu May 27 14:35:55 CEST 2010     root@bigblue.sunshine.ale:/usr/obj/usr/src/sys/BIGBLUE  i386

>Description:
The Falcom Twist USB GSM/GPRS modem is not currently supported by FreeBSD, even latest 8.1-R does not support it.
I 've made a very simple e short patch to add its vendor and product IDs to "uftdi.c" and "usbdevs" files.
A quick test seems to confirm it works.
Unfortunately my patch is just for FreeBSD 6.4-Rp10, but I guess it's not too much different on latest 8.x..

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- uftdi.c.old	2010-11-01 13:22:30.000000000 +0100
+++ uftdi.c	2010-11-01 13:29:48.000000000 +0100
@@ -175,6 +175,7 @@
 	if (uaa->vendor == USB_VENDOR_BBELECTRONICS &&
 	    (uaa->product == USB_PRODUCT_BBELECTRONICS_USOTL4))
 		return (UMATCH_VENDOR_PRODUCT);
+       if (uaa->vendor == USB_VENDOR_FALCOM &&
+           (uaa->product == USB_PRODUCT_FALCOM_TWIST))
                 return (UMATCH_VENDOR_PRODUCT);
@@ -290,6 +291,18 @@
 			goto bad;
 		}
 		break;
+	case USB_VENDOR_FALCOM:
+		switch( uaa->product ){
+		case USB_PRODUCT_FALCOM_TWIST:
+			sc->sc_type = UFTDI_TYPE_8U232AM;
+			sc->sc_hdrlen = 0;
+			break;
+
+		default:		/* Can't happen */
+			goto bad;
+		}
+		break;
 
 	default:		/* Can't happen */
 		goto bad;

--- usbdevs.old	2010-11-01 14:03:28.000000000 +0100
+++ usbdevs	2010-11-01 14:03:45.000000000 +0100
@@ -488,7 +488,7 @@
 vendor NOVATECH		0x0eb0	NovaTech
 vendor EGALAX		0x0eef	eGalax
 vendor MICROTUNE	0x0f4d	Microtune
+vendor FALCOM          0x0f94  Falcom
 vendor VTECH		0x0f88	VTech
 vendor QUALCOMM2	0x1004	Qualcomm
 vendor GIGABYTE		0x1044	GIGABYTE
@@ -1295,8 +1295,8 @@
 /* Microtune, Inc. products */
 product MICROTUNE BT_DONGLE	0x1000	Bluetooth USB dongle
 
+/* Falcom products */
+product FALCOM TWIST		0x0001	USB GSM/GPRS modem
 
 /* Midiman products */
 product MIDIMAN MIDISPORT2X2	0x1001	Midisport 2x2


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011011316.oA1DGu0r046724>