Date: Mon, 7 Jan 2008 22:25:15 GMT From: Piotr Smyrak <smyru@heron.pl> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/119437: [patch] let net-im/loudmouth optionally depend on dns/libidn Message-ID: <200801072225.m07MPF0x087075@www.freebsd.org> Resent-Message-ID: <200801072230.m07MU177040107@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119437
>Category: ports
>Synopsis: [patch] let net-im/loudmouth optionally depend on dns/libidn
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Jan 07 22:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Piotr Smyrak
>Release: 6.2-STABLE
>Organization:
>Environment:
FreeBSD ntbk 6.2-STABLE FreeBSD 6.2-STABLE #0: Tue Jun 5 08:46:50 CEST 2007 root@psmyrak.intra:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Configure bundled with net-im/loudmouth distribution auto-discovers installed dns/libidn, and compiles against it. But this dependency is not recorded by the ports/packages so if one deinstalls libidn as a orphan package, then any port depending on it will break on missing lib dependency.
The attached patch let net-im/loudmouth optionally depend on dns/libidn if it is installed and the sysop did not marked it as unwatned via WITHOUT_IDN, eventually wrapping the distrubution behaviour.
>How-To-Repeat:
Install dns/libidn. Install net-im/loudmouth or any port depending on it like polish/gnugadu2 (WITH_JABBER), then check pkg_info -xR libidn - it should show null. Uninstall libidn, and anything linked against it will break - as follows net-im/loudmouth -> polish/gnugadu2 jabber plugin as well.
>Fix:
Apply the patch
Patch attached with submission follows:
--- Makefile.orig Mon Jan 7 22:38:39 2008
+++ Makefile Mon Jan 7 23:07:05 2008
@@ -35,4 +35,11 @@
CONFIGURE_ARGS+= --without-ssl
.endif
+.if exists(${LOCALBASE}/bin/idn) && !defined(WITHOUT_LIBIDN)
+LIB_DEPENDS+= idn.16:${PORTSDIR}/dns/libidn
+CONFIGURE_ARGS+= --with-libidn=${LOCALBASE}
+.else
+CONFIGURE_ARGS+= --without-libidn
+.endif
+
.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801072225.m07MPF0x087075>