Skip site navigation (1)Skip section navigation (2)
Date:      Wed,  2 Apr 2014 21:33:29 -0400 (EDT)
From:      Nikolai Lifanov <lifanov@mail.lifanov.com>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/188212: [patch] [fix] [update] [stage] multimedia/shell-fm 0.8
Message-ID:  <20140403013329.C30831AF782@mail.lifanov.com>
Resent-Message-ID: <201404030140.s331e0gb072073@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         188212
>Category:       ports
>Synopsis:       [patch] [fix] [update] [stage] multimedia/shell-fm 0.8
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 03 01:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Nikolai Lifanov
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD mail.lifanov.com 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	multimedia/shell-fm didn't actually work for a while now now that Last.fm changed their API.
	The upstream updated this version to 0.8, then later branched the api-v2 version to update it to actually work.

	This PR fixes multimedia/shell-fm runtime by taking a working snapshot some time after v0.8 release with upstream api-v2 fixes applied.

	While at it, stage, modernize, convert to new LIB_DEPENDS, and request to take this port.
	I would like to maintain it, if the current maintainer doesn't object. The version in ports is 5 years old and doesn't work.

	Tested with: manually on two systems, redports

>How-To-Repeat:
	1) install multimedia/shell-fm
	2) try to use it

>Fix:

--- shell-fm.diff begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 349960)
+++ Makefile	(working copy)
@@ -2,30 +2,26 @@
 # $FreeBSD$
 
 PORTNAME=	shell-fm
-PORTVERSION=	0.7
+PORTVERSION=	0.8.20140402
 PORTEPOCH=	2
 CATEGORIES=	multimedia
-MASTER_SITES=	http://nex.scrapping.cc/shell-fm/releases/
+MASTER_SITES=	SF/lifanov-ports-distfiles/${PORTNAME}
 
-MAINTAINER=	ntarmos@cs.uoi.gr
+MAINTAINER=	lifanov@mail.lifanov.com
 COMMENT=	A command-line client for Last.FM
 
-LIB_DEPENDS=	ao:${PORTSDIR}/audio/libao \
-		mad:${PORTSDIR}/audio/libmad
+LIB_DEPENDS=	libao.so:${PORTSDIR}/audio/libao \
+		libmad.so:${PORTSDIR}/audio/libmad
 
 USES=		gmake pkgconfig
-USE_BZIP2=	true
 LDFLAGS+=	-L${LOCALBASE}/lib
 CFLAGS+=	-I${LOCALBASE}/include
 
-MAN1=		shell-fm.1
-MANCOMPRESSED=	yes
-PLIST_FILES=	bin/shell-fm
+PLIST_FILES=	bin/shell-fm man/man1/shell-fm.1.gz
 PORTDOCS=	AUTHORS RELEASE INSTALL
 PORTEXAMPLES=	shell-colors.sh shell-fm-tune.sh \
 		unix.pl zcontrol
 
-NO_STAGE=	yes
 pre-build:
 	@${REINPLACE_CMD} \
 		-e 's/^PREFIX.*$$/\PREFIX := $$(LOCALBASE)/g' \
@@ -32,19 +28,14 @@
 		${WRKSRC}/Makefile
 
 post-install:
-.if !defined(NOPORTDOCS)
-	@${ECHO_MSG} "installing additional documentation to ${DOCSDIR}"
-	@${MKDIR} ${DOCSDIR}
+	${STRIP_CMD} ${STAGEDIR}${LOCALBASE}/bin/shell-fm
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
 . for doc in ${PORTDOCS}
-	@${INSTALL_DATA} ${WRKSRC}/${doc} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/${doc} ${STAGEDIR}${DOCSDIR}
 . endfor
-.endif
-.if !defined(NOPORTEXAMPLES)
-	@${MKDIR} ${EXAMPLESDIR}
-	@${ECHO_MSG} "installing examples to ${EXAMPLESDIR}"
+	${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
 . for example in ${PORTEXAMPLES}
-	@${INSTALL_DATA} ${WRKSRC}/scripts/${example} ${EXAMPLESDIR}
+	${INSTALL_DATA} ${WRKSRC}/scripts/${example} ${STAGEDIR}${EXAMPLESDIR}
 . endfor
-.endif
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
--- distinfo	(revision 349960)
+++ distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (shell-fm-0.7.tar.bz2) = 01262c65735ab2531795a471db845ceed0a3fc3b410e0fe7f75ad12bccca1cdc
-SIZE (shell-fm-0.7.tar.bz2) = 41902
+SHA256 (shell-fm-0.8.20140402.tar.gz) = 689d47bed2c1e339ddf3150edce65f4bfda7bd29166afba397e555cfcb6420e3
+SIZE (shell-fm-0.8.20140402.tar.gz) = 62341
--- shell-fm.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140403013329.C30831AF782>