Date: Mon, 11 Apr 2005 02:11:26 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Harti Brandt <harti@freebsd.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/usr.bin/make cond.c cond.h for.c for.h parse.c parse.h Message-ID: <20050411091126.GA6125@xor.obsecurity.org> In-Reply-To: <20050411101216.N97775@beagle.kn.op.dlr.de> References: <200504110720.j3B7KAIx034955@repoman.freebsd.org> <20050411074021.GA85675@xor.obsecurity.org> <20050411101216.N97775@beagle.kn.op.dlr.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2005 at 11:07:28AM +0200, Harti Brandt wrote: > KK>I assume you've tested that this doesn't cause problems for anything > KK>in the ports collection? >=20 > I didn't test all of the ports collection - just a number of ports. But I= =20 > grepped the ports infrastructure and the ports Makefile* for problematic= =20 > constructs and found one problem that now shows up (under certain=20 > conditions) instead of beeing hidden: >=20 > mail/dspam > mail/dspam-devel >=20 > both of them use >=20 > . elseif ... >=20 > This has been intepreted by make as a plain .else without any warning up= =20 > to now. Now it is just ignored when the .if defined (WITH_MYSQL40) ... is= =20 > false and give an error if it is true. I'll inform the maintainer about= =20 > this. >=20 > There may be of course ports that use our make to build. In any case the= =20 > change to the .else and .endif clauses just give a warning so the ports > maintainer have time to fix this. What could break is the use of=20 > .undefFOO but I don't expect many of them. I really hope this doesn't cause problems, but based on historical precedent I expect that it will. In future, please coordinate troublesome make changes with us (portmgr) so we can test them first and avoid destabilizing the ports collection for the users. Kris --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCWj8+Wry0BWjoQKURAlWLAKCp5QMOJioTBmJCSzF4JmhgPnQHagCgu8Hj zPuu9ivHUOvJf4pu9jYqcGk= =JMq8 -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050411091126.GA6125>