Date: Wed, 27 May 2009 14:39:07 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: rea-fbsd@codelabs.ru Cc: freebsd-hackers@freebsd.org, Jakub Lach <jakub_lach@mailplus.pl> Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file symlink) vulnerability Message-ID: <86prdug1p0.fsf@ds4.des.no> In-Reply-To: <15QQC%2B1YeDzOjf35dqyJmioc1ik@XX1fo6zQUfC4h0jjRC6IBz3oNH4> (Eygene Ryabinkin's message of "Wed, 27 May 2009 16:07:09 %2B0400") References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no> <0vGjPHEq7MqxjtFmBufY%2BmBxlR4@7oUjtCwN654QcDr16CH%2BkAk8bJg> <86vdnmiz30.fsf@ds4.des.no> <15QQC%2B1YeDzOjf35dqyJmioc1ik@XX1fo6zQUfC4h0jjRC6IBz3oNH4>
next in thread | previous in thread | raw e-mail | index | archive | help
Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes: > "Dag-Erling Sm=C3=B8rgrav" <des@des.no> writes: > > (don't be fooled by the comment on line 270; > > the code inside the if statement is for the *non*-symlink case). > Me sees this on the line 226, but may be I hadn't updated my 7.x. I was working on head. The code is (mostly) the same, just shifted somewhere between ~50 and ~90 lines depending on where you look. Your patch should apply cleanly. BTW, you made a lot of whitespace changes in namei.h. This is generally frowned upon, as it makes the functional change almost impossible to spot in the diff. > And yes, I know what was meant by '(cnp->cn_flags & ISSYMLINK) =3D=3D 0' > ;)) I know you know :) I was just pointing out that the comment is misleading. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86prdug1p0.fsf>