Date: Tue, 20 Jan 2015 21:14:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Nathan Whitehorn <nwhitehorn@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r277421 - head/sys/powerpc/powerpc Message-ID: <20150120191438.GL42409@kib.kiev.ua> In-Reply-To: <201501201621.t0KGLx26096724@svn.freebsd.org> References: <201501201621.t0KGLx26096724@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Tue Jan 20 16:21:59 2015 > New Revision: 277421 > URL: https://svnweb.freebsd.org/changeset/base/277421 > > Log: > There does not seem to be any reason to acquire GIANT here. Follow amd64 > in removing it. > > MFC after: 1 month > > Modified: > head/sys/powerpc/powerpc/mem.c > > Modified: head/sys/powerpc/powerpc/mem.c > ============================================================================== > --- head/sys/powerpc/powerpc/mem.c Tue Jan 20 15:45:09 2015 (r277420) > +++ head/sys/powerpc/powerpc/mem.c Tue Jan 20 16:21:59 2015 (r277421) > @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio, > cnt = 0; > error = 0; > > - GIANT_REQUIRED; > - This is not an acquisition, to be pedantic. Really, it is cdevsw which has D_NEEDGIANT flag which acquires Giant. After architectures get rid of GIANT_REQUIRED, flag can be removed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150120191438.GL42409>