Date: Sun, 07 Sep 2014 17:14:22 +0200 From: olli hauer <ohauer@gmx.de> To: Adam Weinberger <adamw@adamw.org> Cc: "apache@FreeBSD.org" <apache@FreeBSD.org>, portmgr@FreeBSD.org Subject: Re: apache 2.2 ports Message-ID: <540C764E.4060308@gmx.de> In-Reply-To: <4D3C03D8-2C96-46BD-B97E-590227C8FEF0@adamw.org> References: <8DF8037F-F9EC-488D-86C4-0923789C174C@adamw.org> <540C33E6.3040805@gmx.de> <4D3C03D8-2C96-46BD-B97E-590227C8FEF0@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-09-07 16:59, Adam Weinberger wrote: > On 7 Sep, 2014, at 6:31, olli hauer <ohauer@gmx.de> wrote: > >> On 2014-09-06 17:24, Adam Weinberger wrote: >>> apache team - >>> >>> So it seems that setting USE_APACHE=22 doesn’t actually depend on apache-2.2. This means that every USE_APACHE=22 port is broken, and as of right now won’t have any 10.1 packages. >>> >>> I’m happy to go through and add "DEFAULT_VERSIONS= APACHE=22” to this ports, but I wanted to check with you guys first. Is that the right way to fix it? Is there something else that can be done to make USE_APACHE=22 actually depend on apache-2.2? >>> >> >> Hi Adam, >> >> could you give the patch below a try? >> I've tested the patch with a small selection from USE_APACHE=(22|22+|24) ports and with the patch bsd.default-versions.mk does not overwrite the requirements. > > That patch works perfectly for me. USE_APACHE=22, 22+, and 24 all do the right thing now. > > However, it doesn’t check against bad values. USE_APACHE=42 just drops the apache dependency altogether... most other USE_* systems put out an error in that situation. > > # Adam Hi Adam, are you sure about bad values? Tested only with simple ports $ cd www/mod_log_sql2 $ sed -i.bak 's/22/42/' Makefile $ make ===> mod_log_sql-1.101_6 : Error from bsd.apache.mk. Illegal use of USE_APACHE ( 42+ ). *** Error code 1 $ cd www/blogsum $ sed -i.bak 's/22/32/' Makefile $ make ===> blogsum-1.1_2 is marked as broken: : Error from bsd.apache.mk. apache24 is installed (or APACHE_PORT is defined) and port requires apache32 at least. *** Error code 1 I have to admit bsd.apache.mk is not optimal, needs a major rewrite and split into separate server / modules files. For server bsd.apache.mk is OK but modules and other stuff should go into a Uses/apache.mk file. -- olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?540C764E.4060308>