Date: Tue, 11 Oct 2016 22:32:24 -0400 From: Jonathan Looney <jonlooney@gmail.com> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307083 - head/sys/netinet Message-ID: <CADrOrmtRV9Fp6gaP2MnD3rNJKQfNDhLBbkjnaG6b9MnBRpO7tA@mail.gmail.com> In-Reply-To: <201610120230.u9C2UYHf046690@repo.freebsd.org> References: <201610120230.u9C2UYHf046690@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 11, 2016 at 10:30 PM, Jonathan T. Looney <jtl@freebsd.org> wrote: > Author: jtl > Date: Wed Oct 12 02:30:33 2016 > New Revision: 307083 > URL: https://svnweb.freebsd.org/changeset/base/307083 > > Log: > Currently, when tcp_input() receives a packet on a session that matches a > TCPCB, it checks (so->so_options & SO_ACCEPTCONN) to determine whether or > not the socket is a listening socket. However, this causes the code to > access a different cacheline. If we first check if the socket is in the > LISTEN state, we can avoid accessing so->so_options when processing > packets > received for ESTABLISHED sessions. > > If INVARIANTS is defined, the code still needs to access both variables > to > check that so->so_options is consistent with the state. > > Reviewed by: gallatin > MFC after: 1 week > Sponsored by: Netflix > This should have also noted: Differential Revision: https://reviews.freebsd.org/D8221 Sorry for the omission! Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADrOrmtRV9Fp6gaP2MnD3rNJKQfNDhLBbkjnaG6b9MnBRpO7tA>