Date: Thu, 20 Nov 2014 14:16:41 -0700 From: Warner Losh <imp@bsdimp.com> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r274661 - in head/sys: conf geom/part modules/geom/geom_part/geom_part_bsd Message-ID: <F1C41330-CD74-472B-87B8-27F14379841F@bsdimp.com> In-Reply-To: <9C548298-57D8-47FF-9C66-438F1B6606FE@bsdimp.com> References: <201411181706.sAIH6eS9051888@svn.freebsd.org> <546CC245.3070700@FreeBSD.org> <B523D699-9766-4806-9499-68FD9FF84437@bsdimp.com> <546CDABC.9020103@FreeBSD.org> <AC547D14-AE9E-4E26-9844-B8B6E7C0050D@bsdimp.com> <546E08BA.1020707@FreeBSD.org> <6A0453EA-0DAC-4901-AF29-F75E2787B76A@bsdimp.com> <546E2826.5080606@FreeBSD.org> <9C548298-57D8-47FF-9C66-438F1B6606FE@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_ABDEF4E9-59FA-4221-A02E-8CAEECC3D6EB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 20, 2014, at 2:14 PM, Warner Losh <imp@bsdimp.com> wrote: >=20 > On Nov 20, 2014, at 10:43 AM, Andrey V. Elsukov <ae@FreeBSD.org> = wrote: >=20 >> On 20.11.2014 20:23, Warner Losh wrote: >>>> since there are some reports about strange behavior of old = utilities >>>> after this commit, maybe we won't repair them by this way? >>>> What you think about this path? >>>=20 >>> It doesn=92t thrill me. What=92s it trying to do? And localizing it = to fsck is useless. And where >>> are these reports? >>=20 >> I already committed it in r274750. >> GEOM_PART class can return partition type via "PART::type" attribute. >> Now fsck uses it and runs fsck_ffs or fsck_msdosfs depending from the >> partition type. >=20 > Why did you even ask me and then commit? >=20 > <annoyed and want to just back it out for spite before even seeing it> >=20 > Grump. And seeing that it was verbatim, I am likely going to back it. Why did = you jump into fix a problem I was fixing in such a bogus way. Warner --Apple-Mail=_ABDEF4E9-59FA-4221-A02E-8CAEECC3D6EB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUblo5AAoJEGwc0Sh9sBEAFZIQANjRi8qW6Q3QdKCnT/kxKktY aJ8VoRKaPCMfyJ6yNQ5+DUR/+jMyJ7TkijWuUK3FSiGl6LGA5KD7dbsZFn/kY4ra YU8QpjwpQsGCNSFJHytha7VwskhIynRhxXfkvcqoN2vjJR/j1V0fZu5VQxOyC5uS GuCSU4Fn2dpkap8trvz5gZnCN6o4azfFpPJ3S2h47vlnXKvOPX1LfbVJ5or6cQuP pJPsORjZm3BlG+IQvXTSI9w0diIBXoLvyEqhFV8LXwMe/y7Br4ytzszClSCyefs7 qmB8clDIxZ9GDglYNTxSelAB60fW9HoNI0b4O7BTG+4xd31jZi0hchqxg2W9CfCu SP5JsbQsaHLwA+t0MaklZyxhyzR2upNfh2alDTGAzjHjSlwnFpid+03JKCjULeit 2Xi+oYS7FdPdfpOwS18wdQG3aTqGcT1GcmWDncvDXDrEJgdmV9e8o6N4CkoaDXE4 rUcdkgwhUHui02IvdeMQ1EnHRkDEQyoL/2RooY3r0IBFs2q0jzqHiIZCrZeBijUS WD5sg3ERFIk5+4s4Y7ungKlLVdThCAoZ8Uh44NjrXQOLWtK6ReRETV51mBSXfxVn F+WcFXjJdngDZak1fkeHm+dSEC5Y87CmMmWCv/2zcuYRC3H674EvQQYplZu0R1LN e+ws1wWE/pQxHVS3+tYZ =TPg4 -----END PGP SIGNATURE----- --Apple-Mail=_ABDEF4E9-59FA-4221-A02E-8CAEECC3D6EB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F1C41330-CD74-472B-87B8-27F14379841F>