Date: Fri, 23 Dec 2011 16:01:06 -0500 From: Eitan Adler <lists@eitanadler.com> To: Erik Cederstrand <erik@cederstrand.dk> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: GCC debug flags cleanup Message-ID: <CAF6rxgn%2BUa7=3kkxr7bKtTe0pK-0L7Mc6D9srucP_Dd3OhHd8Q@mail.gmail.com> In-Reply-To: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk> References: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 22, 2011 at 6:52 AM, Erik Cederstrand <erik@cederstrand.dk> wro= te: > Hi, > > I've created a patch that cleans up FreeBSD Makefiles that unconditionall= y set the -g flag for GCC. The motivation for this is that it should be pos= sible to add or remove this flag globally via e.g. CFLAGS (it's part of my = quest to produce deterministic builds). > > I'm not very familiar with GCC or the build infrastructure, so I'd be gra= teful if someone would review it and possibly commit. > > http://dev.affect-it.dk/gcc_debug_flags.diff Generally include your patches inline, it makes reviewing them easier. Index: sys/amd64/conf/GENERIC =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/amd64/conf/GENERIC (revision 228312) +++ sys/amd64/conf/GENERIC (working copy) @@ -21,7 +21,7 @@ ... -makeoptions DEBUG=3D-g # Build kernel with gdb(1) debug symbols ... This is intentionally left in the config files. This is where the .symbols file comes from in /boot/kernel/. --=20 Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgn%2BUa7=3kkxr7bKtTe0pK-0L7Mc6D9srucP_Dd3OhHd8Q>