Date: Sat, 17 Apr 2010 21:52:25 +0400 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/145787: [patch] net/wireshark: mask c-ares under CARES knob like curl does Message-ID: <86bpdi55ly.fsf@gmail.com> Resent-Message-ID: <201004171800.o3HI06QB042640@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 145787
>Category: ports
>Synopsis: [patch] net/wireshark: mask c-ares under CARES knob like curl does
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Apr 17 18:00:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Prevent the port from silently picking up c-ares dependency.
>How-To-Repeat:
1. install dns/c-ares
2. install net/wireshark
3. check wireshark binary for dependency on libcares.so.2
4. deinstall dns/c-ares, port system shouldn't warn you
>Fix:
--- wireshark.diff begins here ---
Index: net/wireshark/Makefile
===================================================================
RCS file: /a/.cvsup/ports/net/wireshark/Makefile,v
retrieving revision 1.152
diff -u -p -r1.152 Makefile
--- net/wireshark/Makefile 28 Mar 2010 06:41:30 -0000 1.152
+++ net/wireshark/Makefile 17 Apr 2010 17:31:18 -0000
@@ -68,6 +68,7 @@ USE_XORG= x11
OPTIONS= RTP "Enable support for playing back RTP streams" off \
SNMP "Enable SNMP OID translation support" on \
ADNS "Enable asynchronous DNS lookup support" on \
+ CARES "Asynchronous DNS resolution via c-ares" off \
PCRE "Enable regular expression matching support" on \
IPV6 "Enable IPv6 support" on \
GEOIP "Enable GeoIP lookups" on \
@@ -141,6 +142,13 @@ CONFIGURE_ARGS+= --with-adns=${LOCALBASE
CONFIGURE_ARGS+= --with-adns=no
.endif
+.if !defined(WITHOUT_CARES) && !defined(LITE)
+LIB_DEPENDS+= cares.2:${PORTSDIR}/dns/c-ares
+CONFIGURE_ARGS+= --with-c-ares=${LOCALBASE}/lib
+.else
+CONFIGURE_ARGS+= --with-c-ares=no
+.endif
+
.if !defined(WITHOUT_GEOIP) && !defined(LITE)
LIB_DEPENDS+= GeoIP.5:${PORTSDIR}/net/GeoIP
CONFIGURE_ARGS+= --with-geoip=${LOCALBASE}/lib
--- wireshark.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bpdi55ly.fsf>