Date: Sat, 21 Aug 2010 19:47:48 GMT From: vwe@FreeBSD.org To: thomas.swan@gmail.com, vwe@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/139314: [patch] install(1): install -d reports success on failure Message-ID: <201008211947.o7LJlmnw098467@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Old Synopsis: install(1): install -d reports success on failure New Synopsis: [patch] install(1): install -d reports success on failure State-Changed-From-To: open->analyzed State-Changed-By: vwe State-Changed-When: Sat Aug 21 19:42:44 UTC 2010 State-Changed-Why: I'm somewhat undecided about this report. IMO if a tool is being told to do one thing and it can't be done, it can be seen as a failure. If install is able to install a file / directory but isn't able to set modes or owner (when told do set them), it should be seen as a failed job (do everything right or signal error, but not do half the way right). Changing that may break a lot of places where install is being used. I've created a patch for that which is signalling a failure if mode or owner can't be set only when -T has been given. The patch can be found at: http://people.freebsd.org/~vwe/files/patches/pr139314_xinstall.diff but I'm really not happy about that. Either use something similar to my patch or we can close this PR as WONTFIX. http://www.freebsd.org/cgi/query-pr.cgi?pr=139314
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008211947.o7LJlmnw098467>