Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Oct 2011 10:58:21 GMT
From:      Hooman Fazaeli <hoomanfazaeli@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   kern/162028: misplaced #endif in ixgbe.c
Message-ID:  <201110261058.p9QAwL5v038810@red.freebsd.org>
Resent-Message-ID: <201110261100.p9QB0K2X066609@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         162028
>Category:       kern
>Synopsis:       misplaced #endif in ixgbe.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 26 11:00:20 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Hooman Fazaeli
>Release:        7.4-RELEASE
>Organization:
Sepehr S. T. Co. Ltd.
>Environment:
FreeBSD HP04 7.4-RELEASE FreeBSD 7.4-RELEASE #1: Thu May 12 02:24:45 IRDT 2011     admin@:/usr/src/sys/i386/compile/SERVER74-001  i386

>Description:
A misplaced #endif in ixgbe_ioctl() causes interface MTU to become
zero when INET and INET6 are undefined. 

>How-To-Repeat:
See sys/dev/ixgbe/ixgbe.c v 1.53 
function ixgbe_ioctl.
>Fix:


Patch attached with submission follows:

--- ixgbe.c.orig	2011-10-17 20:37:17.000000000 +0330
+++ ixgbe.c	2011-10-17 20:38:40.000000000 +0330
@@ -898,8 +898,8 @@
 				arp_ifinit(ifp, ifa);
 		} else
 			error = ether_ioctl(ifp, command, data);
-		break;
 #endif
+		break;
 	case SIOCSIFMTU:
 		IOCTL_DEBUGOUT("ioctl: SIOCSIFMTU (Set Interface MTU)");
 		if (ifr->ifr_mtu > IXGBE_MAX_FRAME_SIZE - ETHER_HDR_LEN) {


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110261058.p9QAwL5v038810>