Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Feb 2008 02:20:41 GMT
From:      Kip Macy <kmacy@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 135543 for review
Message-ID:  <200802170220.m1H2KfBc097014@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=135543

Change 135543 by kmacy@kmacy:entropy:iwarp on 2008/02/17 02:20:23

	reduce debug noise

Affected files ...

.. //depot/projects/iwarp/sys/dev/cxgb/cxgb_l2t.c#9 integrate
.. //depot/projects/iwarp/sys/dev/cxgb/cxgb_l2t.h#6 integrate

Differences ...

==== //depot/projects/iwarp/sys/dev/cxgb/cxgb_l2t.c#9 (text+ko) ====

@@ -175,11 +175,8 @@
 	sin.sin_family = AF_INET;
 	sin.sin_len = sizeof(struct sockaddr_in);
 	sin.sin_addr.s_addr = e->addr;
-	
-	
-	
-	printf("send slow on rt=%p eaddr=0x%08x\n", rt, e->addr);
-	
+
+	CTR2(KTR_CXGB, "send slow on rt=%p eaddr=0x%08x\n", rt, e->addr);
 again:
 	switch (e->state) {
 	case L2T_STATE_STALE:     /* entry is stale, kick off revalidation */
@@ -199,8 +196,6 @@
 		}
 		arpq_enqueue(e, m);
 		mtx_unlock(&e->lock);
-		printf("enqueueing arp request\n");
-		
 		/*
 		 * Only the first packet added to the arpq should kick off
 		 * resolution.  However, because the m_gethdr below can fail,
@@ -211,7 +206,7 @@
 		 */
 		if (arpresolve(rt->rt_ifp, rt, NULL,
 		     (struct sockaddr *)&sin, e->dmac) == 0) {
-			printf("mac=%x:%x:%x:%x:%x:%x\n",
+			CTR6(KTR_CXGB, "mac=%x:%x:%x:%x:%x:%x\n",
 			    e->dmac[0], e->dmac[1], e->dmac[2], e->dmac[3], e->dmac[4], e->dmac[5]);
 			
 			if ((m = m_gethdr(M_NOWAIT, MT_DATA)) == NULL)
@@ -394,8 +389,6 @@
 	/* Need to allocate a new entry */
 	e = alloc_l2e(d);
 	if (e) {
-		printf("initializing new entry\n");
-		
 		mtx_lock(&e->lock);          /* avoid race with t3_l2t_free */
 		e->next = d->l2tab[hash].first;
 		d->l2tab[hash].first = e;
@@ -470,8 +463,6 @@
 	int hash = arp_hash(addr, ifidx, d);
 	struct llinfo_arp *la;
 
-	printf("t3_l2t_update called with arp info\n");
-	
 	rw_rlock(&d->lock);
 	for (e = d->l2tab[hash].first; e; e = e->next)
 		if (e->addr == addr && e->ifindex == ifidx) {
@@ -479,7 +470,7 @@
 			goto found;
 		}
 	rw_runlock(&d->lock);
-	printf("addr=0x%08x not found\n", addr);
+	CTR1(KTR_CXGB, "t3_l2t_update: addr=0x%08x not found", addr);
 	return;
 
 found:

==== //depot/projects/iwarp/sys/dev/cxgb/cxgb_l2t.h#6 (text+ko) ====

@@ -143,8 +143,6 @@
 	if (__predict_true(e->state == L2T_STATE_VALID)) {
 		return cxgb_ofld_send(dev, (struct mbuf *)m);
 	}
-	printf("send slow\n");
-	
 	return t3_l2t_send_slow(dev, (struct mbuf *)m, e);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802170220.m1H2KfBc097014>