Date: Thu, 23 Jan 2003 15:30:07 -0800 (PST)
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/47406: [Patch] Remove {PERL} from ports@'s ports
Message-ID: <200301232330.h0NNU7EI005549@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47406; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Ulrich Spoerlein <q@uni.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47406: [Patch] Remove {PERL} from ports@'s ports
Date: Fri, 24 Jan 2003 00:29:02 +0100
--=.454rcGxWX_NfW/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Ulrich Spoerlein told:
> diff -urN /usr/ports/misc/xrmap/Makefile xrmap/Makefile
[...]
> + @${CAT} ${PKGMESSAGE} | ${SED} "s,%%PREFIX%%,${PREFIX},"
save a process today, don't uselessly use cat!
@${SED} -e 's#%%PREFIX%%#${PREFIX}#' < ${PKGMESSAGE}
attention committers:
files/pkg-message.in removed
pkg-message added
> diff -urN /usr/ports/x11/xcolorsel/Makefile xcolorsel/Makefile
[...]
> -WRKSRC= $(WRKDIR)/xcolorsel
> +WRKSRC= ${WRKDIR}/xcolorsel
woot?
[...]
> + @${REINPLACE_CMD} -e 's|app2head|./app2head|g' \
> + -e 's|XawClientLibs|-lXaw3d \$$\(XMULIBONLY\) \$$\(XTOOLLIB\) \$$\(XPMLIB) \$$\(XLIB\)|g' ${WRKSRC}/Imakefile
you don't need to escape parentheses and $ in this context:
-e 's|XawClientLibs|-lXaw3d $$(XMULIBONLY) $$(XTOOLLIB) $$(XPMLIB) $$(XLIB)|g' ${WRKSRC}/Imakefile
> diff -urN /usr/ports/deskutils/gnofin/Makefile gnofin/Makefile
[...]
> + ${REINPLACE_CMD} -E -e 's|-lpthread|${PTHREAD_LIBS}|g' \
> + -e 's|DATADIRNAME=lib|DATADIRNAME=share|g' \
> + -e 's|USE_INCLUDED_LIBINTL=yes|#USE_INCLUDED_LIBINTL=yes|g' \
> + -e 's|\$$\(top_builddir\)/intl/libintl.a|-lintl|g' ${WRKSRC}/configure
what for -E ?
either this way or without -E and without escaping the parentheses
(looks better to me)
> + find ${WRKSRC} -name "Makefile.in" | ${XARGS} ${REINPLACE_CMD} -E\
> + -e 's|\$$\(datadir\)/gnome/|\$$\(datadir\)/|g' \
> + -e 's|\$$\(datadir\)/locale|\$$\(prefix\)/share/locale|g'
same issue + no need to \-escape $ and () in the replacement
> diff -urN /usr/ports/security/fwbuilder/Makefile fwbuilder/Makefile
[...]
> + @${REINPLACE_CMD} -e 's/lc_r/pthread/' ${WRKSRC}/configure ;\
use ${PTHREAD_LIBS}?
[...]
> + @${REINPLACE_CMD} -e 's|^CFLAGS\s+=\s+-Wall\s+-g|CFLAGS = \@CFLAGS@ -Wall|' ${WRKSRC}/src/$i
did you test this? sed doesn't know \s, just [[:space:]]
you don't need to escape @ in sed
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--=.454rcGxWX_NfW/
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+MHrBr5S+dk6z85oRAhGxAKD6T39r9z/OCLjnpWzVFyKIfDflqACfUQ+p
QP1fI0LVYLbhS5TyWoONEx0=
=eDNP
-----END PGP SIGNATURE-----
--=.454rcGxWX_NfW/--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301232330.h0NNU7EI005549>