Date: Sun, 21 Aug 2011 12:28:24 +0100 From: Chris Rees <utisoft@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: freebsd-rc@freebsd.org, Colin Percival <cperciva@freebsd.org> Subject: Re: RC script for spiped (cperciva's latest invention) Message-ID: <CADLo83-Lq0uGYRFg27VbfjnWtHKCkKKzGkQ4XuagXU_8owqLeA@mail.gmail.com> In-Reply-To: <4E5041CA.3030108@FreeBSD.org> References: <CADLo83-7zmLvxN3NktvFSas7n1Lv6sOLwqOH9NA5HquYb-Jkag@mail.gmail.com> <4E5041CA.3030108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 August 2011 00:22, Doug Barton <dougb@freebsd.org> wrote: > On 08/20/2011 02:41, Chris Rees wrote: >> Hi all, >> >> Colin's submitted a port for his spiped program, with an rc script and >> I figure I should get it reviewed after my tweaks. >> >> Please refer to [1] for the provisional file, and the original PR is at = [2]. >> >> Thanks! >> >> Chris >> >> [1] http://www.bayofrum.net/~crees/patches/spiped-rc-script >> >> [2] http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/159899 > > Attached is a patch that includes a couple of minor style issues, and > more importantly local'izing the variables used in the functions. > Otherwise it looks good to me. > > > hth, > > Doug Very much appreciated. Thanks! Chris --=20 Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-Lq0uGYRFg27VbfjnWtHKCkKKzGkQ4XuagXU_8owqLeA>