Date: Sun, 8 Nov 2009 10:55:38 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 170348 for review Message-ID: <200911081055.nA8Atcns074144@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/chv.cgi?CH=170348 Change 170348 by hselasky@hselasky_laptop001 on 2009/11/08 10:54:42 LibUSB v1.0 - fix a possible device leak. Affected files ... .. //depot/projects/usb/src/lib/libusb/libusb10.c#14 edit Differences ... ==== //depot/projects/usb/src/lib/libusb/libusb10.c#14 (text+ko) ==== @@ -186,8 +186,6 @@ /* create libusb v1.0 compliant devices */ i = 0; while ((pdev = libusb20_be_device_foreach(usb_backend, NULL))) { - /* get device into libUSB v1.0 list */ - libusb20_be_dequeue_device(usb_backend, pdev); dev = malloc(sizeof(*dev)); if (dev == NULL) { @@ -200,6 +198,10 @@ libusb20_be_free(usb_backend); return (LIBUSB_ERROR_NO_MEM); } + + /* get device into libUSB v1.0 list */ + libusb20_be_dequeue_device(usb_backend, pdev); + memset(dev, 0, sizeof(*dev)); /* init transfer queues */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911081055.nA8Atcns074144>