Date: Fri, 6 Nov 2009 13:22:02 -0500 From: John Baldwin <jhb@freebsd.org> To: Gavin Atkinson <gavin@freebsd.org> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r198987 - in head/sys/dev: an ixgb vge Message-ID: <200911061322.02504.jhb@freebsd.org> In-Reply-To: <1257525277.64262.5.camel@buffy.york.ac.uk> References: <200911061452.nA6Eqbxm020072@svn.freebsd.org> <1257525277.64262.5.camel@buffy.york.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 06 November 2009 11:34:37 am Gavin Atkinson wrote: > On Fri, 2009-11-06 at 14:52 +0000, John Baldwin wrote: > > Author: jhb > > Date: Fri Nov 6 14:52:37 2009 > > New Revision: 198987 > > URL: http://svn.freebsd.org/changeset/base/198987 > > > > Log: > > Use device_printf() and if_printf() instead of printf() with an explicit > > unit number and remove 'unit' members from softc. > > > > Modified: > > head/sys/dev/an/if_an.c > [snip] > > This covers most, but not all of my PR 126924 - is there any chance you > could look at the rest of it? (I can create a new patch if you wish). Actually, I didn't touch if_an_pci.c, so I think the patch in the PR still applies. The PR patch looks good to me. I can commit it in a second. Do you still have the an(4) card? If so, would you be able to test the patch at http://www.FreeBSD.org/~jhb/patches/cleanup.patch? For an(4) specifically it fixes several issues in the locking as well as changing the watchdog handling to not use the deprecated if_watchdog interface. Thanks. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911061322.02504.jhb>