Date: Wed, 1 Oct 2003 06:20:07 -0700 (PDT) From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/57451: Upgrade security/clamav-devel Message-ID: <200310011320.h91DK7el083892@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/57451; it has been noted by GNATS. From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Rob Evers <rob@debank.tv> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/57451: Upgrade security/clamav-devel Date: Wed, 01 Oct 2003 15:16:00 +0200 Hi Rob, thanks a lot for the quick response. And keep up the good work. Just a few remarks: > +# > +# $FreeBSD: ports/security/clamav/files/clamd.sh,v 1.1 2003/09/28 13:29:28 dinoex Exp $ > +# => should be $FreeBSD$ > +name=clamav_clamd Any reason for the name change, especially since your script isn't named clamav_clamd.sh? > +clamav_clamd_enable=${clamav_clamd_enable:-"NO"} > +clamav_clamd_flags=${clamav_clamd_flags:-""} > +clamd_socket=${clamd_socket:-"%%CLAMD_SOCKET%%"} => clamav_clamd_socket then, but I would prefer clamd... > +# $FreeBSD: ports/security/clamav/files/clamd.sh,v 1.1 2003/09/28 13:29:28 dinoex Exp $ see above > +# PROVIDE: clamav-milter you don't. you provide clamav_milter. > +# REQUIRE: LOGIN I don't know clamav structure, but I assume you require clamd? > +command=%%PREFIX%%/sbin/clamd && %%PREFIX%%/sbin/clamav-milter you are calling %%PREFIX%%/sbin/clamav-milter here, surely not what you want. How about command=%%PREFIX%%/sbin/clamav-milter > +pidfile=/var/run/clamav/clamd.pid That's already the pidfile of clamd > + rm "$clamd_socket" And now you kill clamds socket. > + rm -f $pidfile see above > diff -ruN clamav-devel.orig/pkg-deinstall clamav-devel/pkg-deinstall > --- clamav-devel.orig/pkg-deinstall Thu Jan 1 01:00:00 1970 > +++ clamav-devel/pkg-deinstall Wed Oct 1 14:04:48 2003 > @@ -0,0 +1,4 @@ > +echo "----------------------------------------------------------" > +echo " If you really want to remove this package, please remove" > +echo " the clamav-user and clean out log files " > +echo "----------------------------------------------------------" Great, but you should check for POST-DEINSTALL here. And you *could* tell the users to do `pw userdel clamav', I can see no harm in that. But is is fine as it is. Regards, and thanks for the great work with the clamav-devel port Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310011320.h91DK7el083892>