Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Jun 2001 12:14:48 -0400
From:      Garance A Drosihn <drosih@rpi.edu>
To:        obrien@FreeBSD.org, Garance A Drosehn <gad@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/sh eval.c
Message-ID:  <p05100e00b73d683af6e4@[128.113.24.47]>
In-Reply-To: <20010531231614.A64344@dragon.nuxi.com>
References:  <200106010007.f5107AY14009@freefall.freebsd.org> <20010531231614.A64344@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
At 11:16 PM -0700 5/31/01, David O'Brien wrote:
>On Thu, May 31, 2001, Garance A Drosehn wrote:
>  >   Modified files:
>>      bin/sh               eval.c
>>    Log:
>  >   Fix how /bin/sh handles 'for' and 'case' statements when it is
>  >   called to do errexit (-e) processing.
>
>Was this reviewed by cracauer?  He has been doing the care and
>feeding of ash for along time and he really up on the subtleties
>of the various standards that address `sh'.

I sent a message on Monday, but haven't received a reply.  And
the more I've looked at the code, the more I'm sure that the
fix I went with is appropriate.  The patch also includes comments
explaining exactly why it's appropriate, for the next person
who looks at the routine in question.

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05100e00b73d683af6e4>