Date: Tue, 23 Jun 2009 07:10:14 +0800 From: Adrian Chadd <adrian@freebsd.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: Roman Divacky <rdivacky@freebsd.org>, current@freebsd.org, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: [PATCH]: if (cond); foo() in firewire Message-ID: <d763ac660906221610j5aa8f085uc78be271d98f1c11@mail.gmail.com> In-Reply-To: <4A3F6917.7040806@icyb.net.ua> References: <20090621082022.GA88526@freebsd.org> <d763ac660906212104w4bf066eatf5529779e603bd0e@mail.gmail.com> <20090622045428.GA18123@troutmask.apl.washington.edu> <4A3F6917.7040806@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/6/22 Andriy Gapon <avg@icyb.net.ua>: > You confuse me. It is a "vanilla userland transfer", but so? > Current code always goes to "out" label regardless if uimove succeeded or not. > I think the idea was to go "out" only if uimove failed and execute some code > between if and out-label otherwise. Because now you have a code path being run which hasn't been run for quite a while. I'm just saying be careful, and don't assume that "clang found a bug". It found a bad code construct. Changing that bit of code changes the flow of execution and may change things unexpectedly in later code. It's the same with any bug - this "found by clang" bug should be looked at by someone who knows the firewire code and they haven't replied to this thread. :) I'm glad clang has this lexical analysis magic. Shouldn't there be some kind of weird, magical, standalone "lint" program to do this kind of lexical checking for us? :) Adrian Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d763ac660906221610j5aa8f085uc78be271d98f1c11>