Date: Tue, 19 Apr 2016 09:16 -0700 From: John Baldwin <jhb@freebsd.org> To: Marcelo Araujo <araujo@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 Message-ID: <4114217.PtcV9LDMal@ralph.baldwin.cx> In-Reply-To: <201604190446.u3J4kD9G050780@repo.freebsd.org> References: <201604190446.u3J4kD9G050780@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: > Author: araujo > Date: Tue Apr 19 04:46:13 2016 > New Revision: 298247 > URL: https://svnweb.freebsd.org/changeset/base/298247 > > Log: > Remove redundant parenthesis. > > Submitted by: pfg > MFC after: 2 weeks. For this case, it might be better to remove numentries and use nitems() directly in the one place it is used. I would probably even do this as a for-loop: struct part_type *ptr; int counter; for (counter = 0, ptr = part_types; counter < nitems(part_types); counter++, ptr++) { if (ptr->type == (type & 0x7f)) return (ptr->name); } return ("unknown"); If you renamed 'counter' to 'i' you could probably fit it all on one line. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4114217.PtcV9LDMal>