Date: Fri, 13 Jul 2007 11:43:16 -0700 From: Julian Elischer <julian@elischer.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: Attilio Rao <attilio@freebsd.org>, FreeBSD Current <current@freebsd.org> Subject: Re: crash in tty code in 6.1.. fixed since? Message-ID: <4697C7C4.3070500@elischer.org> In-Reply-To: <20070713082705.GI2200@deviant.kiev.zoral.com.ua> References: <46970DF7.3000803@elischer.org> <46972B28.1010409@FreeBSD.org> <20070713082705.GI2200@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
>>> tp_session is NULL but it shouldn't have been able to have run that line >>> (line 1659) if it had tested NULL 2 lines before.. >>> this suggests a locking problem.. >> I think it has been fixed some months ago IIRC. >> The problem here, should be that if sx_slock() let thread sleep, Giant >> is released before to sleep and tp->t_session can be accessed in racy way. >> Another nice side-effect about having tty Giant :) > > Yes, it seems that rev. 1.267 fixed it and was MFCed as rev. 1.228.2.6. > There was a lot of commits around this one, it may be safer to update to > RELENG_6. That's not an option on a product. 6.1 has passed all sorts of QA benchmarks etc. and while we will upgrade, it will probably happen next year.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4697C7C4.3070500>