Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Oct 2006 13:53:51 GMT
From:      Olivier Houchard <cognet@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 107307 for review
Message-ID:  <200610051353.k95DrpXa038271@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107307

Change 107307 by cognet@cognet on 2006/10/05 13:53:41

	Remove a non-working workaround in pmap_remove_pages(), add a more
	useful KASSERT instead.

Affected files ...

.. //depot/projects/arm/src/sys/arm/arm/pmap.c#26 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/arm/pmap.c#26 (text+ko) ====

@@ -2783,13 +2783,8 @@
 		l2b = pmap_get_l2_bucket(pmap, pv->pv_va);
 		KASSERT(l2b != NULL, ("No L2 bucket in pmap_remove_pages"));
 		pt = &l2b->l2b_kva[l2pte_index(pv->pv_va)];
-		if ((*pt & L2_ADDR_MASK) == 0) {
-			npv = TAILQ_NEXT(pv, pv_plist);
-			TAILQ_REMOVE(&pmap->pm_pvlist, pv, pv_plist);
-			pmap_free_pv_entry(pv);
-			continue;
-		}
 		m = PHYS_TO_VM_PAGE(*pt & L2_ADDR_MASK);
+		KASSERT((vm_offset_t)m >= KERNBASE, ("Trying to access non-existent page va %x pte %x", va, *pt));
 		*pt = 0;
 		PTE_SYNC(pt);
 		npv = TAILQ_NEXT(pv, pv_plist);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610051353.k95DrpXa038271>