Date: Fri, 28 Aug 2015 18:31:08 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Julien Charbon <jch@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287196 - head/sys/kern Message-ID: <55E08CCC.6010208@selasky.org> In-Reply-To: <201508270815.t7R8FXek029896@repo.freebsd.org> References: <201508270815.t7R8FXek029896@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/27/15 10:15, Julien Charbon wrote: > Author: jch > Date: Thu Aug 27 08:15:32 2015 > New Revision: 287196 > URL: https://svnweb.freebsd.org/changeset/base/287196 > > Log: > In callout_stop(), if a callout is both pending and currently > being serviced return 0 (fail) but it is applicable only > mpsafe callouts. Thanks to hselasky for finding this. > > Differential Revision: https://reviews.freebsd.org/D3078 (Updated) > Submitted by: hselasky > Reviewed by: jch > Hi, I suggest that this special case be made into a new function, named callout_drain_async() inspired from projects/hps_head and that r287196 be backed out, so that callout_stop() works like before. See: https://reviews.freebsd.org/D3521 And that the following patch be MFC'ed to -current from projects/hps_head after D3521. https://svnweb.freebsd.org/changeset/base/287261 It should close the race in question. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55E08CCC.6010208>