Date: Mon, 27 May 2002 22:47:14 +0200 (CEST) From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> To: FreeBSD-gnats-submit@FreeBSD.org Subject: docs/38631: Update notes on CVS commit messages in Committers' Guide Message-ID: <200205272047.g4RKlE963257@pulcherrima.dbai.tuwien.ac.at>
next in thread | raw e-mail | index | archive | help
>Number: 38631 >Category: docs >Synopsis: Update notes on CVS commit messages in Committers' Guide >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon May 27 13:50:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: FreeBSD 4.5-RELEASE i386 >Organization: >Environment: >Description: This updates the notes on CVS commit messages in the Committer's Guide by explicitly adding (what is apparently) common wisdom concerning references to other committers. >How-To-Repeat: >Fix: Patch below; especially the end of the last chunk of this patch should be closely checked for markup issues. Index: article.sgml =================================================================== RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v retrieving revision 1.125 diff -u -3 -p -r1.125 article.sgml --- article.sgml 26 May 2002 23:35:19 -0000 1.125 +++ article.sgml 27 May 2002 20:30:13 -0000 @@ -2422,28 +2422,34 @@ cvs add: use 'cvs commit' to add this fi <row> <entry><literal>Submitted by:</literal></entry> <entry>The name and e-mail address of the person that - submitted the fix.</entry> + submitted the fix; for committers, just the username on + the FreeBSD cluster.</entry> </row> <row> <entry><literal>Reviewed by:</literal></entry> <entry>The name and e-mail address of the person or people - that reviewed the change. If a patch was submitted to a - mailing list for review, and the review was favorable, - then just include the list name.</entry> + that reviewed the change; for committers, just the + username on the FreeBSD cluster. If a patch was + submitted to a mailing list for review, and the review + was favorable, then just include the list name.</entry> </row> <row> <entry><literal>Approved by:</literal></entry> <entry>The name and e-mail address of the person or people - that approved the change. It is customary to get prior - approval for a commit if it is to an area of the tree to - which you do not usually commit. In addition, during the - run up to a new release all commits - <emphasis>must</emphasis> be approved by the release - engineer. If these are your first commits then you should - have passed them past your mentor first for approval, and - you should list your mentor.</entry> + that approved the change; for committers, just the + username on the FreeBSD cluster. It is customary to get + prior approval for a commit if it is to an area of the + tree to which you do not usually commit. In addition, + during the run up to a new release all commits + <emphasis>must</emphasis> be approved by the release + engineering team. If these are your first commits then + you should have passed them past your mentor first, and + you should list your mentor, as in + ``<replaceable>username-of-mentor</replaceable> + <literal>(mentor)</literal>''. + </entry> </row> <row> >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205272047.g4RKlE963257>