Date: Sun, 25 Oct 2009 23:56:29 +0100 From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: glarkin@FreeBSD.org Subject: ports/139975: [PATCH] graphics/GraphicsMagick13: missing support for png, jpeg and others Message-ID: <4ae4d79f.0b38560a.542d.4ad3@mx.google.com> Resent-Message-ID: <200910252300.n9PN0CFd079945@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 139975 >Category: ports >Synopsis: [PATCH] graphics/GraphicsMagick13: missing support for png, jpeg and others >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Oct 25 23:00:12 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Marcin Wisnicki >Release: FreeBSD 7.2-STABLE i386 >Organization: >Environment: System: FreeBSD ghost.pnet.one.pl 7.2-STABLE FreeBSD 7.2-STABLE #3: Sat Oct 17 20:50:32 CEST 2009 >Description: When building with OPENMP (default) LDFLAGS variable in CONFIGURE_ENV is overriden. Unfortunately configure script will continue and automatically disable failing components. This results in a build that's missing all functionality provided by dependencies (libpng, lipjpeg, etc). Following patch adjusts LDFLAGS properly. For completeness some kind of modification to configure script is need so that it will always fail hard in case of errors. Alternate versions of port likely have similar problems. Port maintainer (glarkin@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- GraphicsMagick-1.3.7_1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/graphics/GraphicsMagick13.orig/Makefile /usr/ports/graphics/GraphicsMagick13/Makefile --- /usr/ports/graphics/GraphicsMagick13.orig/Makefile 2009-10-18 04:08:17.000000000 +0200 +++ /usr/ports/graphics/GraphicsMagick13/Makefile 2009-10-25 17:38:16.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= GraphicsMagick PORTVERSION= 1.3.7 +PORTREVISION= 1 CATEGORIES= graphics MASTER_SITES= SF \ ftp://ftp.graphicsmagick.org/pub/GraphicsMagick/1.3/ @@ -54,7 +55,8 @@ ALL_TARGET= -j`${SYSCTL} -n hw.ncpu` CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib" + LDFLAGS="${CONFIGURE_LDFLAGS}" +CONFIGURE_LDFLAGS=-L${LOCALBASE}/lib test check: cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} check @@ -79,6 +81,8 @@ .endif .endif +# XXX configure will continue even if optional components don't work + .if defined(WITH_FPX) LIB_DEPENDS+= fpx.[2-9]:${PORTSDIR}/graphics/libfpx CONFIGURE_ARGS+= --with-fpx @@ -98,7 +102,7 @@ IGNORE= does not support OpenMP on FreeBSD version ${OSVERSION} .endif -CONFIGURE_ENV+= LDFLAGS=${PTHREAD_LIBS} +CONFIGURE_LDFLAGS+= ${PTHREAD_LIBS} CONFIGURE_ARGS+= --with-threads --enable-openmp --disable-openmp-slow .else CONFIGURE_ARGS+= --without-threads --disable-openmp --- GraphicsMagick-1.3.7_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ae4d79f.0b38560a.542d.4ad3>