Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Mar 2008 22:46:35 GMT
From:      Chess Griffin <chess@chessgriffin.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/121304: [patch] multimedia/audacious-plugins: add FLAC option, also add Jack to pkg-plist
Message-ID:  <200803022246.m22MkZHQ056564@www.freebsd.org>
Resent-Message-ID: <200803022250.m22Mo0rK056891@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         121304
>Category:       ports
>Synopsis:       [patch] multimedia/audacious-plugins:  add FLAC option, also add Jack to pkg-plist
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 02 22:50:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Chess Griffin
>Release:        7.0-RELEASE
>Organization:
>Environment:
FreeBSD bsdbob.localdomain 7.0-RELEASE FreeBSD 7.0-RELEASE #1: Mon Feb 25 19:09:06 EST 2008     chess@bsdbob.localdomain:/usr/obj/usr/src/sys/CHESS  i386
>Description:
I built the new 1.4.5 audacious-plugins on my tinderbox and noticed two issues:  first, the new FLAC input plugin option was not listed in the OPTIONS= section and second, if Jack is selected as a build option, then it's not listed in pkg-plist and doesn't get removed.  These two issues should be fixed in this patch.  I also bumped the PORTREVISION to 1.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN audacious-plugins.orig/Makefile audacious-plugins/Makefile
--- audacious-plugins.orig/Makefile	2008-03-02 15:54:03.000000000 -0500
+++ audacious-plugins/Makefile	2008-03-02 17:48:16.000000000 -0500
@@ -7,6 +7,7 @@
 
 PORTNAME=	audacious-plugins
 PORTVERSION=	1.4.5
+PORTREVISION=	1
 CATEGORIES=	multimedia audio
 MASTER_SITES=	http://distfiles.atheme.org/
 EXTRACT_SUFX=	.tgz
@@ -47,6 +48,7 @@
 		ROOTVIS		"Enable X11 RootWindow vis plugin"      on  \
 		ADPLUG		"Enable AdPlug plugin"			off \
 		VORBIS		"Enable Ogg Vorbis input plugin"	off \
+		FLAC		"Enable FLAC input plugin"		off \
 		WAVPACK 	"Enable WavPack input plugin"		off \
 		AAC		"Enable aac plugin"			on  \
 		SNDFILE 	"Enable sndfile extensions"		off \
diff -ruN audacious-plugins.orig/pkg-plist audacious-plugins/pkg-plist
--- audacious-plugins.orig/pkg-plist	2008-03-02 15:54:03.000000000 -0500
+++ audacious-plugins/pkg-plist	2008-03-02 15:56:40.000000000 -0500
@@ -37,6 +37,7 @@
 lib/audacious/Input/wav.so
 %%WAVPACKPLUGIN%%lib/audacious/Input/wavpack.so
 %%WMAPLUGIN%%lib/audacious/Input/wma.so
+%%JACKPLUGIN%%lib/audacious/Output/jackout.so
 %%OSSPLUGIN%%lib/audacious/Output/OSS.so
 %%ESDPLUGIN%%lib/audacious/Output/ESD.so
 %%ARTSPLUGIN%%lib/audacious/Output/arts.so


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803022246.m22MkZHQ056564>