Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jul 2007 15:13:50 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-hackers@freebsd.org, John-Mark Gurney <gurney_j@resnet.uoregon.edu>
Cc:        Christopher Davis <loafier@freebsd.org>, multimedia@freebsd.org
Subject:   Re: Audio driver template
Message-ID:  <200707101513.50869.jhb@freebsd.org>
In-Reply-To: <20070710020921.GB1221@funkthat.com>
References:  <c44ca55f0707091147n48741250h588a1fcf59d1b74b@mail.gmail.com> <20070710020921.GB1221@funkthat.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 09 July 2007 10:09:21 pm John-Mark Gurney wrote:
> Christopher Davis wrote this message on Mon, Jul 09, 2007 at 11:47 -0700:
> > http://people.freebsd.org/~cg/template.c
> > 
> > Thought I would take a look at the audio driver template as
> > part of my task to modernize drivers, soc2007. I would simplify
> > the read and write functions to avoid using the bus tag and
> > handle, but I'm not sure what else to do to bring it up to date.
> > 
> > How else can it be improved?
> 
> Use bus_alloc_resources instead of using bus_alloc_resource...
> Maybe use pci_enable_busmaster and friends instead of using
> pci_write_config...  (In the future for suspend/resume, I would hope
> our pci layer would save the state, which it might not if you write
> directly to the config registers.)

It already saves the state, and it does so by reading all the regs during 
suspend, so that backdoor writes are saved and restored.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707101513.50869.jhb>