Date: Tue, 24 Apr 2001 13:11:12 +0200 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: smp@FreeBSD.ORG Subject: Re: Kernel include file cleanup take #3. Message-ID: <200104241109.f3OB9Uw63269@gratis.grondar.za> In-Reply-To: <Pine.BSF.4.21.0104242030390.15368-100000@besplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Tue, 24 Apr 2001 20:34:27 %2B1000." References: <Pine.BSF.4.21.0104242030390.15368-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, 23 Apr 2001, Mark Murray wrote: > > > > > http://people.freebsd.org/~markm/patches/sys.SYS_MUTEX.diff.1 > > > > You actually made <sys/lockmgr.h> a subinclude of > > > other headers that need it, and one that doesn't (<sys/conf.h> doesn't > > > need it directly, but it includes <sys/eventhandler.h> which does). > > > > OK. Removed it (plus some other junk) from eventhandler. > > From conf? Eventhandler now contains all it needs, and conf.h includes eventhandler.h. conf.h no longer contains lock junk. > > OK. Done. For such small files I'd prefer them to be owned by the project, > > but I don't care enough to be religious about it. > > Actually, the copyrights from the original files would be better. That works for me. > > > I'm not sure if the names for the new types headers are right. Perhaps > > > they should have a leading underscore to inhibit direct inclusion, or > > > not have the "_types" suffix, to make them less verbose and not hint > > > that they are limited to types. > > > > How about _mutex.h and _lock.h? > > OK. Roger that. Done. > The pfind() changes gave about another .c files that need <sys/mutex.h> > but don't include it. Bleagh. I'll fix that. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104241109.f3OB9Uw63269>