Date: Sat, 15 Jul 2006 16:35:03 +0200 From: Divacky Roman <xdivac02@stud.fit.vutbr.cz> To: John Baldwin <jhb@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 101643 for review Message-ID: <20060715143502.GA77297@stud.fit.vutbr.cz> In-Reply-To: <200607151003.28710.jhb@freebsd.org> References: <200607150905.k6F959IT031112@repoman.freebsd.org> <200607151003.28710.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 15, 2006 at 10:03:28AM -0400, John Baldwin wrote: > On Saturday 15 July 2006 05:05, Roman Divacky wrote: > > http://perforce.freebsd.org/chv.cgi?CH=101643 > > > > Change 101643 by rdivacky@rdivacky_witten on 2006/07/15 09:04:22 > > > > Several things at once: > > > > o Change process_exit and process_exec function handlers prototype > > to include struct image_params arg. > > Why did you add it to process_exit()? exit() doesn't have an imgp to > pass, so this doesn't make sense. If you are doing it so you can use > the same function for both, then use a wrapper in the exit() case or some > such. because most users of process_exec eventhandler use the same function both for process_exit and process_exec. I didnt know how to solve that otherwise. in the process_exit case I pass in NULL and I change all the other users to foo(void *arg, struct proc *p, struct image_params *imgp __unused) if its not ok tell me how to change that
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060715143502.GA77297>