Date: Wed, 26 May 2010 11:58:10 -0700 From: Sean Bruno <seanbru@yahoo-inc.com> To: Garrett Cooper <yanefbsd@gmail.com> Cc: "sbruno@freebsd.org" <sbruno@freebsd.org>, freebsd-hackers <freebsd-hackers@freebsd.org> Subject: Re: Exposing Zone Sleeps Message-ID: <1274900290.2481.135.camel@localhost.localdomain> In-Reply-To: <AANLkTikfzFFNSg0ZqYmsmobpkCxcRsS0rx9HYJ_bCvWK@mail.gmail.com> References: <1274739973.31299.23.camel@localhost.localdomain> <4BFBD838.40208@dataix.net> <4BFC1660.1000405@dataix.net> <AANLkTimkvxtzMWuvfOLWy5SKQH9kTUow0F2I5nJtGL48@mail.gmail.com> <AANLkTikfzFFNSg0ZqYmsmobpkCxcRsS0rx9HYJ_bCvWK@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2010-05-26 at 11:52 -0700, Garrett Cooper wrote:
> >>
> >> This patch instead pardon the early.post but there was a problem with
> >> the last patch that I attached for stable/8 r208530 with arguments 10 &
> >> 11 to function sysctl_vm_zone where it wanted a long unsigned integer
> >> rather than u_int64_t.
> >>
> >> This patch satisfies that. Whether its correct is left to the reader but
> >> compiles cleanly & runs smoothly.
> >
> > I know this seems trivial, but could you change:
> >
> > + printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
> > + "LIMIT", "USED", "FREE", "REQ", "FAIL", "SLEEP");
> >
> > to
> >
> > + printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
> > + "LIMIT", "USED", "FREE", "REQS", "FAIL", "SLEEP");
> >
> > that way the plural nature of requests is more straightforward and understood.
> >
> > Also, do all of the fields _really_ need to have a field width? Seems
> > like overkill to me...
>
> Oh, and the field width for the last item is wrong; SLEEP will be
> truncated to SLEE.
> Thanks,
> -Garrett
I hate this type of column implementation. Any ideas on a more useful
implementation?
also, I'm missing an email in this thread somehow. I didn't see the
second version of the REL-8 patch.
Sean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1274900290.2481.135.camel>