Date: Sun, 13 Apr 2014 12:57:56 +0200 (CEST) From: Rafael Ostertag <rafi@guengel.ch> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/188550: [patch] print/cups-base missing rc script for cups-browsed Message-ID: <201404131057.s3DAvuO7008330@beastie.kruemel.home> Resent-Message-ID: <201404131100.s3DB00o4009574@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188550
>Category: ports
>Synopsis: [patch] print/cups-base missing rc script for cups-browsed
>Confidential: no
>Severity: non-critical
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 13 11:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Rafael Ostertag <rafi@guengel.ch>
>Release: FreeBSD 10.0-RELEASE-p1 amd64
>Organization:
>Environment:
System: FreeBSD beastie.kruemel.home 10.0-RELEASE-p1 FreeBSD 10.0-RELEASE-p1 #0 r264354: Fri Apr 11 23:35:31 CEST 2014 root@beastie.kruemel.home:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
As of r351201, print/cups-base seems to be missing a rc script for starting cups-browsed.
>How-To-Repeat:
Install print/cups-base. There is only /usr/local/etc/rc.d/cupsd which apparently only starts cupsd.
>Fix:
Attached a patch that provides files/cups_browsed.in and alters USE_RC_SUBR in Makefile to include the rc script.
--- cups-base.diff begins here ---
Index: Makefile
===================================================================
--- Makefile (revision 351200)
+++ Makefile (working copy)
@@ -107,7 +107,7 @@
BUILD_DEPENDS+= cups-client${PKGNAMESUFFIX2}>=${PORTVERSION}:${PORTSDIR}/${PKGCATEGORY}/cups-client
BUILD_DEPENDS+= cups-image${PKGNAMESUFFIX2}>=${PORTVERSION}:${PORTSDIR}/${PKGCATEGORY}/cups-image
COMMENT2= Server
-USE_RC_SUBR= cupsd
+USE_RC_SUBR= cupsd cups_browsed
PLIST_SUB+= CACHEDIR="${CUPS_CACHEDIR}"
.if ${ARCH} == "ia64"
BROKEN= stack-protector not supported on ia64
Index: files/cups_browsed.in
===================================================================
--- files/cups_browsed.in (revision 0)
+++ files/cups_browsed.in (working copy)
@@ -0,0 +1,29 @@
+#!/bin/sh
+
+# $FreeBSD$
+#
+# PROVIDE: cups_browsed
+# REQUIRE: LOGIN
+# KEYWORD: shutdown
+#
+# Add the following to /etc/rc.conf[.local] to enable this service
+#
+# cups_browsed_enable (bool): Set to NO by default.
+# Set it to YES to enable cups_browsed.
+#
+
+. /etc/rc.subr
+
+name=cups_browsed
+rcvar=cups_browsed_enable
+
+load_rc_config ${name}
+
+ : ${cups_browsed_enable:=NO}
+
+command=/usr/sbin/daemon
+pidfile=/var/run/cups-browsed.pid
+command_args="-p ${pidfile} %%PREFIX%%/sbin/cups-browsed"
+procname="%%PREFIX%%/sbin/cups-browsed"
+
+run_rc_command "$1"
Property changes on: files/cups_browsed.in
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
--- cups-base.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404131057.s3DAvuO7008330>