Date: Thu, 25 May 2006 07:55:09 -0700 From: Sam Leffler <sam@errno.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_taskqueue.c Message-ID: <4475C54D.5040009@errno.com> In-Reply-To: <20060525111300.GJ27819@FreeBSD.org> References: <200605242211.k4OMB8rY077596@repoman.freebsd.org> <20060525111300.GJ27819@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff wrote: > Sam, > > On Wed, May 24, 2006 at 10:11:08PM +0000, Sam Leffler wrote: > S> sam 2006-05-24 22:11:08 UTC > S> > S> FreeBSD src repository > S> > S> Modified files: > S> sys/kern subr_taskqueue.c > S> Log: > S> When starting up threads in taskqueue_start_threads create them > S> stopped before adjusting their priority and setting them on the run > S> q so they cannot race for resources (pointed out by njl). > S> > S> While here add a console printf on thread create fails; otherwise > S> noone may notice (e.g. return value is always 0 and caller has no > S> way to verify). > S> > S> Reviewed by: jhb, scottl > S> MFC after: 2 weeks > > Since "pointed out by njl", I hope that this fix for the ACPI problem that > prevented merging the new taskqueue code to RELENG_6? It's unlikely, but jhb's changes to correct priority propagation might have helped. We were never able to get enough information to diagnose the ACPI problem. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4475C54D.5040009>