Date: Mon, 17 May 2010 23:08:22 +0530 From: "C. Jayachandran" <c.jayachandran@gmail.com> To: Neel Natu <neelnatu@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Minor fixup for the MIPS SMP platform code. Message-ID: <AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE@mail.gmail.com> In-Reply-To: <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com> References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com> <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000e0cd138e0fbebda0486cdb051 Content-Type: text/plain; charset=ISO-8859-1 On Mon, May 17, 2010 at 9:08 PM, Neel Natu <neelnatu@gmail.com> wrote: > Hi JC, > > Your patch looks good. Thanks for cleaning up the platform-specific > code from mp_machdep.c. > > There are a couple of style things you might want to take care of: > > 1. In hwfunc.h there is an extra space after the '*' in the > declaration of platform_smp_topo() > > 2. In platform_smp_topo() for XLR: > - Values in return statements should be enclosed in parantheses. > - space around binary operator '/' > > Looks like I've been a bit sloppy here, updated patch attached, with all the comments so far addressed. Thanks, JC. > best > Neel > > On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran > <c.jayachandran@gmail.com> wrote: > > The attached patch (also at > > http://sites.google.com/site/cjayachandran/files) has two changes: > > - moves the intr masking code to platform_init_ap, so that we can avoid > the > > #ifdef for XLR > > - adds a platform_smp_topo() function so that platforms can define their > > topology > > > > I've also attempted to fixup sys/mips/sibyte to reflect these changes, > but > > it might need further work. > > sys/mips/cavium also might need similar changes for SMP. > > > > Please review and apply if the changes are okay. > > > > Thanks, > > JC. > > > > > -- C. Jayachandran c.jayachandran@gmail.com --000e0cd138e0fbebda0486cdb051 Content-Type: application/octet-stream; name="mips-smp-fixup.patch" Content-Disposition: attachment; filename="mips-smp-fixup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g9bk0xqp0 SW5kZXg6IHN5cy9taXBzL3NpYnl0ZS9zYl9tYWNoZGVwLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL21p cHMvc2lieXRlL3NiX21hY2hkZXAuYwkocmV2aXNpb24gMjA4MTg5KQorKysgc3lzL21pcHMvc2li eXRlL3NiX21hY2hkZXAuYwkod29ya2luZyBjb3B5KQpAQCAtMzQ0LDkgKzM0NCwxNiBAQAogCXJl dHVybiAoNCk7CiB9CiAKK3N0cnVjdCBjcHVfZ3JvdXAgKgorcGxhdGZvcm1fc21wX3RvcG8odm9p ZCkKK3sKKwlyZXR1cm4gKHNtcF90b3BvX25vbmUoKSk7Cit9CisKIHZvaWQKIHBsYXRmb3JtX2lu aXRfYXAoaW50IGNwdWlkKQogeworCWludCBpcGlfaW50X21hc2ssIGNsb2NrX2ludF9tYXNrOwog CiAJS0FTU0VSVChjcHVpZCA9PSAxLCAoIkFQIGhhcyBhbiBpbnZhbGlkIGNwdSBpZCAlZCIsIGNw dWlkKSk7CiAKQEAgLTM1Niw2ICszNjMsMTMgQEAKIAlrc2VnMF9tYXBfY29oZXJlbnQoKTsKIAog CXNiX2ludHJfaW5pdChjcHVpZCk7CisKKwkvKgorCSAqIFVubWFzayB0aGUgY2xvY2sgYW5kIGlw aSBpbnRlcnJ1cHRzLgorCSAqLworCWNsb2NrX2ludF9tYXNrID0gaGFyZF9pbnRfbWFzayg1KTsK KwlpcGlfaW50X21hc2sgPSBoYXJkX2ludF9tYXNrKHBsYXRmb3JtX2lwaV9pbnRybnVtKCkpOwor CXNldF9pbnRyX21hc2soQUxMX0lOVF9NQVNLICYgfihpcGlfaW50X21hc2sgfCBjbG9ja19pbnRf bWFzaykpOwogfQogCiBpbnQKSW5kZXg6IHN5cy9taXBzL2luY2x1ZGUvaHdmdW5jLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gc3lzL21pcHMvaW5jbHVkZS9od2Z1bmMuaAkocmV2aXNpb24gMjA4MTg5KQorKysg c3lzL21pcHMvaW5jbHVkZS9od2Z1bmMuaAkod29ya2luZyBjb3B5KQpAQCAtOTMsNSArOTMsMTEg QEAKICAqLwogZXh0ZXJuIGludCBwbGF0Zm9ybV9udW1fcHJvY2Vzc29ycyh2b2lkKTsKIAorLyoK KyAqIFJldHVybiB0aGUgdG9wb2xvZ3kgb2YgcHJvY2Vzc29ycyBvbiB0aGlzIHBsYXRmb3JtCisg Ki8KK3N0cnVjdCBjcHVfZ3JvdXAgKnBsYXRmb3JtX3NtcF90b3BvKHZvaWQpOworCisKICNlbmRp ZgkvKiBTTVAgKi8KICNlbmRpZiAvKiAhX01BQ0hJTkVfSFdGVU5DX0hfICovCkluZGV4OiBzeXMv bWlwcy9ybWkveGxyX21hY2hkZXAuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvbWlwcy9ybWkveGxyX21h Y2hkZXAuYwkocmV2aXNpb24gMjA4MTg5KQorKysgc3lzL21pcHMvcm1pL3hscl9tYWNoZGVwLmMJ KHdvcmtpbmcgY29weSkKQEAgLTUzNCw2ICs1MzQsOCBAQAogCiAJLyogU2V0dXAgaW50ZXJydXB0 cyBmb3Igc2Vjb25kYXJ5IENQVXMgaGVyZSAqLwogCXN0YXQgPSBtaXBzX3JkX3N0YXR1cygpOwor CUtBU1NFUlQoKHN0YXQgJiBNSVBTX1NSX0lOVF9JRSkgPT0gMCwKKwkgICAgKCJJbnRlcnJ1cHRz IGVuYWJsZWQgaW4gJXMhIiwgX19mdW5jX18pKTsKIAlzdGF0IHw9IE1JUFNfU1JfQ09QXzJfQklU IHwgTUlQU19TUl9DT1BfMF9CSVQ7CiAJbWlwc193cl9zdGF0dXMoc3RhdCk7CiAKQEAgLTU3MCw0 ICs1NzIsMTEgQEAKIHsKIAlyZXR1cm4gZmxzKHhscl9ib290MV9pbmZvLmNwdV9vbmxpbmVfbWFw KTsKIH0KKworc3RydWN0IGNwdV9ncm91cCAqCitwbGF0Zm9ybV9zbXBfdG9wbygpCit7CisJcmV0 dXJuIChzbXBfdG9wb18ybGV2ZWwoQ0dfU0hBUkVfTDIsIHBsYXRmb3JtX251bV9wcm9jZXNzb3Jz KCkgLyA0LAorCSAgICBDR19TSEFSRV9MMSwgNCwgQ0dfRkxBR19USFJFQUQpKTsKK30KICNlbmRp ZgpJbmRleDogc3lzL21pcHMvbWlwcy9tcGJvb3QuUwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvbWlwcy9t aXBzL21wYm9vdC5TCShyZXZpc2lvbiAyMDgxODkpCisrKyBzeXMvbWlwcy9taXBzL21wYm9vdC5T CSh3b3JraW5nIGNvcHkpCkBAIC03NiwxMCArNzYsOCBAQAogCiAJUFRSX0xBCWdwLCBfQ19MQUJF TChfZ3ApCiAKLSNpZm5kZWYgVEFSR0VUX1hMUl9YTFMKIAlqYWwJcGxhdGZvcm1faW5pdF9hcAog CW1vdmUJYTAsIHMwCi0jZW5kaWYKIAlqYWwJc21wX2luaXRfc2Vjb25kYXJ5CiAJbW92ZQlhMCwg czAKIApJbmRleDogc3lzL21pcHMvbWlwcy9tcF9tYWNoZGVwLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lz L21pcHMvbWlwcy9tcF9tYWNoZGVwLmMJKHJldmlzaW9uIDIwODE4OSkKKysrIHN5cy9taXBzL21p cHMvbXBfbWFjaGRlcC5jCSh3b3JraW5nIGNvcHkpCkBAIC0xOTYsOCArMTk2LDcgQEAKIHN0cnVj dCBjcHVfZ3JvdXAgKgogY3B1X3RvcG8odm9pZCkKIHsKLQotCXJldHVybiAoc21wX3RvcG9fbm9u ZSgpKTsKKwlyZXR1cm4gKHBsYXRmb3JtX3NtcF90b3BvKCkpOwogfQogCiBpbnQKQEAgLTIzOCwx MCArMjM3LDYgQEAKIHZvaWQKIHNtcF9pbml0X3NlY29uZGFyeSh1X2ludDMyX3QgY3B1aWQpCiB7 Ci0jaWZuZGVmIFRBUkdFVF9YTFJfWExTCi0JaW50IGlwaV9pbnRfbWFzaywgY2xvY2tfaW50X21h c2s7Ci0jZW5kaWYKLQogCS8qIFRMQiAqLwogCU1pcHNfU2V0V0lSRUQoMCk7CiAJTWlwc19UTEJG bHVzaChudW1fdGxiZW50cmllcyk7CkBAIC0yOTQsMTggKzI4OSw3IEBACiAJd2hpbGUgKHNtcF9z dGFydGVkID09IDApCiAJCTsgLyogbm90aGluZyAqLwogCi0jaWZuZGVmIFRBUkdFVF9YTFJfWExT CiAJLyoKLQkgKiBVbm1hc2sgdGhlIGNsb2NrIGFuZCBpcGkgaW50ZXJydXB0cy4KLQkgKi8KLQlj bG9ja19pbnRfbWFzayA9IGhhcmRfaW50X21hc2soNSk7Ci0JaXBpX2ludF9tYXNrID0gaGFyZF9p bnRfbWFzayhwbGF0Zm9ybV9pcGlfaW50cm51bSgpKTsKLQlzZXRfaW50cl9tYXNrKEFMTF9JTlRf TUFTSyAmIH4oaXBpX2ludF9tYXNrIHwgY2xvY2tfaW50X21hc2spKTsKLSNlbHNlCi0JcGxhdGZv cm1faW5pdF9hcChjcHVpZCk7Ci0jZW5kaWYKLQotCS8qCiAJICogQm9vdHN0cmFwIHRoZSBjb21w YXJlIHJlZ2lzdGVyLgogCSAqLwogCW1pcHNfd3JfY29tcGFyZShtaXBzX3JkX2NvdW50KCkgKyBj b3VudGVyX2ZyZXEgLyBoeik7Cg== --000e0cd138e0fbebda0486cdb051--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE>