Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Jul 2013 18:08:31 +0200 (CEST)
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/180269: [patch] sysutils/pftop: set CSTD=gnu89
Message-ID:  <201307041608.r64G8Vjs007488@kalimero.tijl.coosemans.org>
Resent-Message-ID: <201307041610.r64GA2xB091417@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         180269
>Category:       ports
>Synopsis:       [patch] sysutils/pftop: set CSTD=gnu89
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 04 16:10:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
Problems with inline and clang are because clang defaults to C99.
Instead of patching the code just use C89.
>How-To-Repeat:
>Fix:

--- pftop.patch begins here ---
Index: sysutils/pftop/Makefile
===================================================================
--- sysutils/pftop/Makefile	(revision 322214)
+++ sysutils/pftop/Makefile	(working copy)
@@ -34,6 +34,7 @@ CFLAGS+=	-DHAVE_FINE_GRAINED_LOCKING=1
 
 EXTRA_PATCHES+=	${FILESDIR}/extra-patch-engine.c
 
+MAKE_ARGS+=	CSTD=gnu89
 MAKE_ENV+=	__MAKE_CONF=/dev/null
 
 PLIST_FILES=	sbin/pftop
@@ -43,7 +44,6 @@ post-patch:
 	    ${WRKSRC}/engine.c
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.h
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.c
-	@${REINPLACE_CMD} -e 's|__inline__|static __inline__|g' ${WRKSRC}/pftop.c
 	@${REINPLACE_CMD} -e 's|#include <net/if_pflog.h>||g' \
 	    ${WRKSRC}/sf-gencode.c
 
--- pftop.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307041608.r64G8Vjs007488>