Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Dec 2007 07:24:27 GMT
From:      John Birrell <jb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 132078 for review
Message-ID:  <200712300724.lBU7ORkO098201@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=132078

Change 132078 by jb@jb_freebsd1 on 2007/12/30 07:24:25

	We use the END() macro to do what OpenSolaris uses SET_SIZE() for.
	Their name makes more sense considering that the macro only sets
	the .size.

Affected files ...

.. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/i386/dtrace_asm.S#4 edit

Differences ...

==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/i386/dtrace_asm.S#4 (text+ko) ====

@@ -33,7 +33,7 @@
 	ENTRY(dtrace_getfp)
 	movl	%ebp, %eax
 	ret
-	SET_SIZE(dtrace_getfp)
+	END(dtrace_getfp)
 
 /*
 uint32_t dtrace_cas32(uint32_t *target, uint32_t cmp, uint32_t new)
@@ -47,8 +47,8 @@
 	lock
 	cmpxchgl %ecx, (%edx)
 	ret
-	SET_SIZE(dtrace_casptr)
-	SET_SIZE(dtrace_cas32)
+	END(dtrace_casptr)
+	END(dtrace_cas32)
 
 /*
 uintptr_t dtrace_caller(int aframes)
@@ -57,7 +57,7 @@
 	ENTRY(dtrace_caller)
 	movl	$-1, %eax
 	ret
-	SET_SIZE(dtrace_caller)
+	END(dtrace_caller)
 
 /*
 void dtrace_copy(uintptr_t src, uintptr_t dest, size_t size)
@@ -80,7 +80,7 @@
 	movl	%ebp, %esp
 	popl	%ebp
 	ret
-	SET_SIZE(dtrace_copy)
+	END(dtrace_copy)
 
 /*
 void dtrace_copystr(uintptr_t uaddr, uintptr_t kaddr, size_t size)
@@ -113,7 +113,7 @@
 	popl	%ebp
 	ret
 
-	SET_SIZE(dtrace_copystr)
+	END(dtrace_copystr)
 
 /*
 uintptr_t dtrace_fulword(void *addr)
@@ -124,7 +124,7 @@
 	xorl	%eax, %eax
 	movl	(%ecx), %eax
 	ret
-	SET_SIZE(dtrace_fulword)
+	END(dtrace_fulword)
 
 /*
 uint8_t dtrace_fuword8_nocheck(void *addr)
@@ -135,7 +135,7 @@
 	xorl	%eax, %eax
 	movzbl	(%ecx), %eax
 	ret
-	SET_SIZE(dtrace_fuword8_nocheck)
+	END(dtrace_fuword8_nocheck)
 
 /*
 uint16_t dtrace_fuword16_nocheck(void *addr)
@@ -146,7 +146,7 @@
 	xorl	%eax, %eax
 	movzwl	(%ecx), %eax
 	ret
-	SET_SIZE(dtrace_fuword16_nocheck)
+	END(dtrace_fuword16_nocheck)
 
 /*
 uint32_t dtrace_fuword32_nocheck(void *addr)
@@ -157,7 +157,7 @@
 	xorl	%eax, %eax
 	movl	(%ecx), %eax
 	ret
-	SET_SIZE(dtrace_fuword32_nocheck)
+	END(dtrace_fuword32_nocheck)
 
 /*
 uint64_t dtrace_fuword64_nocheck(void *addr)
@@ -170,7 +170,7 @@
 	movl	(%ecx), %eax
 	movl	4(%ecx), %edx
 	ret
-	SET_SIZE(dtrace_fuword64_nocheck)
+	END(dtrace_fuword64_nocheck)
 
 /*
 void dtrace_probe_error(dtrace_state_t *state, dtrace_epid_t epid, int which, int fault, int fltoffs, uintptr_t illval)
@@ -190,7 +190,7 @@
 	movl	%ebp, %esp
 	popl	%ebp
 	ret
-	SET_SIZE(dtrace_probe_error)
+	END(dtrace_probe_error)
 
 /*
 void dtrace_membar_producer(void)
@@ -199,7 +199,7 @@
 	ENTRY(dtrace_membar_producer)
 	rep;	ret	/* use 2 byte return instruction when branch target */
 			/* AMD Software Optimization Guide - Section 6.2 */
-	SET_SIZE(dtrace_membar_producer)
+	END(dtrace_membar_producer)
 
 /*
 void dtrace_membar_consumer(void)
@@ -208,4 +208,4 @@
 	ENTRY(dtrace_membar_consumer)
 	rep;	ret	/* use 2 byte return instruction when branch target */
 			/* AMD Software Optimization Guide - Section 6.2 */
-	SET_SIZE(dtrace_membar_consumer)
+	END(dtrace_membar_consumer)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712300724.lBU7ORkO098201>