Date: Sun, 13 Apr 2014 23:40:41 GMT From: Matthew Rezny <matthew@reztek.cz> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/188579: QupZilla port lacks options for DE integration Message-ID: <201404132340.s3DNefZX013278@cgiserv.freebsd.org> Resent-Message-ID: <201404132350.s3DNo08I072303@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188579
>Category: ports
>Synopsis: QupZilla port lacks options for DE integration
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 13 23:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Matthew Rezny
>Release: 10-STABLE
>Organization:
RezTek, s.r.o.
>Environment:
FreeBSD desktop.reztek 10.0-STABLE FreeBSD 10.0-STABLE #0 r264285: Thu Apr 10 01:49:39 CEST 2014 root@desktop.reztek:/usr/obj/usr/src/sys/DESKTOP amd64
>Description:
QupZilla has build options for integration with KDE and Gnome desktop environments. The integration allows utilization of the native password storage mechanism of these DEs (KWallet in the case of KDE, Gnome Keyring in the case of Gnome) for storing of login credentials for websites as an alternative to storing those credentials in a database specifc to QupZilla. Use of the DE's password storage potentially allows the credentials to be shared across multiple browsers. This integration is provided through native browser plugins that can be compiled with the browser. Since these plugins require libraries provided by these DEs, they should be selectively enabled via port options.
>How-To-Repeat:
Desire to save your passwords in one central location rather than separately in each browser.
>Fix:
Add port options for the DE integration plugins. I have prepared a patch to do so. I havfe tested the KWALLET option. I have not tested the GNOMEKEYRING option since I am not a Gnome user.
This patch also includes plist corrections for recently added translations which I had neglected to include in my patch in ports/186810 in my haste to update and un-BROKEN this port.
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 348839)
+++ Makefile (working copy)
@@ -21,6 +21,21 @@
USE_LDCONFIG= yes
INSTALLS_ICONS= yes
+OPTIONS_DEFINE= GNOMEKEYRING KWALLET
+OPTIONS_SUB= yes
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MGNOMEKEYRING}
+LIB_DEPENDS+= libgnome-keyring.so:${PORTSDIR}/security/libgnome-keyring
+QMAKE_ENV+= GNOME_INTEGRATION="true"
+.endif
+
+.if ${PORT_OPTIONS:MKWALLET}
+LIB_DEPENDS+= libkdeui.so:${PORTSDIR}/x11/kdelibs4
+QMAKE_ENV+= KDE_INTEGRATION="true"
+.endif
+
post-patch:
@${REINPLACE_CMD} -e 's|/usr|${LOCALBASE}|g' \
${WRKSRC}/tests/autotests/qztoolstest.cpp \
Index: pkg-plist
===================================================================
--- pkg-plist (revision 348839)
+++ pkg-plist (working copy)
@@ -4,7 +4,9 @@
lib/libQupZilla.so.1.6
lib/libQupZilla.so.1.6.3
lib/qupzilla/libAccessKeysNavigation.so
+%%GNOMEKEYRING%%lib/qupzilla/libGnomeKeyringPasswords.so
lib/qupzilla/libGreaseMonkey.so
+%%KWALLET%%lib/qupzilla/libKWalletPasswords.so
lib/qupzilla/libMouseGestures.so
lib/qupzilla/libPIM.so
lib/qupzilla/libStatusBarIcons.so
@@ -24,7 +26,9 @@
%%DATADIR%%/locale/de_DE.qm
%%DATADIR%%/locale/el_GR.qm
%%DATADIR%%/locale/es_ES.qm
+%%DATADIR%%/locale/es_MX.qm
%%DATADIR%%/locale/es_VE.qm
+%%DATADIR%%/locale/eu_ES.qm
%%DATADIR%%/locale/fa_IR.qm
%%DATADIR%%/locale/fr_FR.qm
%%DATADIR%%/locale/gl_ES.qm
@@ -77,6 +81,7 @@
%%DATADIR%%/locale/sr_RS@latin.qm
%%DATADIR%%/locale/sv_SE.qm
%%DATADIR%%/locale/uk_UA.qm
+%%DATADIR%%/locale/uz@Latn.qm
%%DATADIR%%/locale/zh_CN.qm
%%DATADIR%%/locale/zh_TW.qm
%%DATADIR%%/themes/chrome/images/blankbutton-a.png
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404132340.s3DNefZX013278>