Date: Sat, 08 Feb 2014 16:36:11 -0500 From: John Baldwin <jhb@freebsd.org> To: Roger Pau Monne <roger.pau@citrix.com> Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org Subject: Re: [PATCH RFC 07/13] xen: implement IO APIC support in Xen mptable parser Message-ID: <11166680.j6yj7PCWSG@ralph.baldwin.cx> In-Reply-To: <1387884062-41154-8-git-send-email-roger.pau@citrix.com> References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-8-git-send-email-roger.pau@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, December 24, 2013 12:20:56 PM Roger Pau Monne wrote: > Use madt_setup_io (from madt.c) on Xen apic_enumerator, in order to > parse the interrupt sources from the IO APIC. > > I would like to get opinions, but I think we should rename and move > madt_setup_io to io_apic.c. It wouldn't be appropriate for io_apic.c as it isn't generic to I/O APICs but is specific to ACPI. However, mptable.c is really not a great name for this file in sys/x86/xen. I wonder if it should be xen_apic.c instead? Also, if Xen PV has an MADT table, why do you need a custom APIC enumerator at all? That is, what is preventing the code in madt.c from just working? Do you just not have 'device acpi' in the kernel config you are using? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11166680.j6yj7PCWSG>