Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Jun 2008 22:42:25 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 143092 for review
Message-ID:  <200806072242.m57MgPpv082451@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=143092

Change 143092 by hselasky@hselasky_laptop001 on 2008/06/07 22:42:15

	
	Some small improvements related to the previous IFC.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/if_ural.c#55 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/if_ural.c#55 (text+ko) ====

@@ -2416,7 +2416,12 @@
 	struct ieee80211_node *ni;
 	struct mbuf *m;
 
-	while (sc->sc_tx_queue.ifq_len < IFQ_MAXLEN) {
+	/*
+	 * We only fill up half of the queue with data frames. The rest is
+	 * reserved for other kinds of frames.
+	 */
+
+	while (sc->sc_tx_queue.ifq_len < (IFQ_MAXLEN / 2)) {
 
 		IFQ_DRV_DEQUEUE(&ifp->if_snd, m);
 		if (m == NULL)
@@ -2719,7 +2724,6 @@
 	struct ural_softc *sc = ifp->if_softc;
 
 	mtx_lock(&(sc->sc_mtx));
-
 	if (params == NULL) {
 		/*
 		 * Legacy path; interpret frame contents to decide
@@ -2733,13 +2737,6 @@
 		 */
 		ural_tx_raw(sc, m, ni, params);
 	}
-	m = NULL;
 	mtx_unlock(&(sc->sc_mtx));
-
-	if (m) {
-		m_freem(m);
-		ieee80211_free_node(ni);
-		return (ENETDOWN);
-	}
 	return (0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806072242.m57MgPpv082451>