Date: Wed, 26 May 2010 17:31:17 -0400 From: jhell <jhell@dataix.net> To: Sean Bruno <seanbru@yahoo-inc.com> Cc: freebsd-hackers <freebsd-hackers@freebsd.org>, "sbruno@freebsd.org" <sbruno@freebsd.org> Subject: Re: Exposing Zone Sleeps Message-ID: <4BFD9325.50905@dataix.net> In-Reply-To: <1274894969.2481.47.camel@localhost.localdomain> References: <1274739973.31299.23.camel@localhost.localdomain> <4BFBD838.40208@dataix.net> <1274798852.4715.1.camel@localhost.localdomain> <1274894969.2481.47.camel@localhost.localdomain>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/26/2010 13:29, Sean Bruno wrote: > On Tue, 2010-05-25 at 07:47 -0700, Sean Bruno wrote: >>> Hi Sean, >>> >>> Nice work on this. I applied this to stable/8 r208530 and I am in the >>> process of compiling the kernel right now. Everything else has built & >>> runs as expected "i386". Attached is the adjusted patch which was one >>> modification to the line number for uz_sleeps in sys/vm/uma_int.h. >>> >>> 8 files changed, 106 insertions(+), 7 deletions(-) >>> >>> For those wishing to apply this patch and test for them self: >>> >>> cd /usr/src >>> patch </path/to/sleep_stat_stable8_r208530.diff >>> cd /usr/src/include >>> make obj && make depend && make includes && make install >>> cd /usr/src/lib/libmemstat >>> make obj && make depend && make includes && make install >>> cd /usr/src/usr.bin/vmstat >>> make obj && make depend && make install >>> cd /usr/src >>> make kernel KERNCONF=YOUR_KERN_CONF >>> reboot >>> >>> Can't wait to see some results from this & I will report back with >>> either negative results of the build & run or positive results from the >>> stats collected. >>> >>> If there is anything needed feel free to let me know and I will do what >>> is possible ASAP. >>> >>> Thanks again, >>> >>> - -- >>> >>> jhell >> >> Excellent. Please check the output of vmstat -z and the appropriate >> sysctl. I changed the display a bit to keep it from wrapping on a >> standard terminal. >> >> Sean >> >> P.S. My intention it to MFC this to all releases. >> > > I do have a concern related to the removal of an #ifdef DDB in this > patch. Any comments? > > Sean This was in your original patch sent to the list. I questioned it too but as far as testing it goes it has caused no harm that I can see here but I will add those back in along with the improvements from Garrett, then regenerate the patch and send it back to the list. Regards, -- jhell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BFD9325.50905>