Date: Fri, 16 Mar 2001 10:26:33 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Soren Schmidt <sos@freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/atacontrol pathnames.h Makefile atacontrol.8 atacontrol.c Message-ID: <20010316102633.D62097@sunbay.com> In-Reply-To: <200103152001.VAA73815@freebsd.dk>; from sos@freebsd.dk on Thu, Mar 15, 2001 at 09:01:22PM %2B0100 References: <200103152001.VAA73815@freebsd.dk> <200103152011.VAA76337@freebsd.dk> <200103151928.f2FJSwi60381@freefall.freebsd.org> <200103152001.VAA73815@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Soren! Please take my public apologies for this. I was about to fix the markup of the manual page when I ran the program without arguments to see its usage() and it segfaulted. I was really frustrated. Anyway, this should not have been a motivation for my further actions. I am really sorry... On Thu, Mar 15, 2001 at 09:01:22PM +0100, Soren Schmidt wrote: [...] > > I would have liked you to pass this by me first, now I have to go > through the hell of merging this with what I got here. On Thu, Mar 15, 2001 at 09:11:05PM +0100, Soren Schmidt wrote: [...] > > Actually you have broken atacontrol, its no longer possible to > set the transfer mode of one device only... > Index: atacontrol.c =================================================================== RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v retrieving revision 1.2 diff -u -p -r1.2 atacontrol.c --- atacontrol.c 2001/03/15 19:28:58 1.2 +++ atacontrol.c 2001/03/16 08:25:13 @@ -206,8 +206,6 @@ main(int argc, char **argv) modes.channel = atoi(argv[2]); modes.mode[0] = str2mode(argv[3]); modes.mode[1] = str2mode(argv[4]); - if (modes.mode[0] == -1 || modes.mode[1] == -1) - usage(); if (ioctl(fd, ATASMODE, &modes) == -1) err(1, "ioctl(ATASMODE)"); else Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010316102633.D62097>