Date: Wed, 11 May 2011 22:26:19 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: Damjan Marion <damjan.marion@gmail.com> Cc: freebsd-hackers@freebsd.org, Adrian Chadd <adrian@freebsd.org> Subject: Re: Embedded switch instead of stadard PHY Message-ID: <65747DF5-AAE5-446C-A162-7AE167D992A0@semihalf.com> In-Reply-To: <84255DD0-2593-4F24-8536-2C015CE11DC4@gmail.com> References: <34CF3ED0-52BC-4D0E-922A-FE26F624E77F@gmail.com> <BANLkTi=mr0f_t6aitbq%2BhF951C%2BEq9UuBw@mail.gmail.com> <84255DD0-2593-4F24-8536-2C015CE11DC4@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2011-05-08, at 11:36, Damjan Marion wrote: >=20 > On May 8, 2011, at 9:58 AM, Adrian Chadd wrote: >=20 >> On 8 May 2011 01:22, Damjan Marion <damjan.marion@gmail.com> wrote: >>=20 >>> I would like to implement support for embedded switch on WRT350Nv2 = router which is based on 88F5181L SoC (ARM). FreeBSD already have = support for embedded gigabit card (if_mge) but in case if this router = MAC is connected directly to 8-port ethernet chip (88E6131). If I use = MII_PHY_ANY scan founds following PHYs on miibus: >>=20 >> There's been some discussions in the past about how to implement a >> switch PHY API for use by the variety of embedded switch devices out >> there. >>=20 >> There's been a few attempts at it too. >>=20 >> What I think may just be a good first step is to port over the Linux >> driver for it and instead of trying to make it appear as a multi-PHY >> device, just export a programming and status interface via sysctl. >> That at least gets the thing in the tree and functioning. Once we = have >> a few devices in the tree and functioning, we'll be in a better >> position to have a discussion about how to represent it. >>=20 >> There's a couple of dissenting views about how it should be >> implemented. I'd like to see some working code in the tree so some >> discussion can occur, rather than lots of dissent and no discussion. >> :) >>=20 >> (The switch phy is the last remaining bit of the board support for a >> handful of boards too, so I'd really like to see it completed. :) >=20 > Hi Adrian, >=20 > I agree with your approach. At this point my concern is how to change = existing code to support switch PHY. In my case problem is that = mii_attach as it is today cannot be used detect this device as device is = not using standard registers. >=20 > I can see 2 possible options: > 1. Modifying eth driver in the way that if switch phy is detected then = it avoids calling mii_attach. Drawback of this approach is that it will = need applying same code for each pair of MAC-switch PHY >=20 > 2. Modifying mii_attach in the way that it is more flexible in = detecting such devices. This looks challenging to me to do this in = flexible way. >=20 > What do you think? FWIW, there's a couple of items already available for the 88E6xxx switch = support, which you can try to use as a base for further work: * Juli Mallet's driver, which is currently in HEAD (used by Cavium = MIPS): - http://fxr.watson.org/fxr/source/mips/cavium/octe/mv88e61xxphy.c - http://fxr.watson.org/fxr/source/mips/cavium/octe/mv88e61xxphyreg.h * My team's early experimental work: - http://people.freebsd.org/~raj/misc/e6000sw.c - http://people.freebsd.org/~raj/misc/e6000swreg.h Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?65747DF5-AAE5-446C-A162-7AE167D992A0>