Date: Thu, 25 Sep 2014 20:31:03 +0000 From: bugzilla-noreply@freebsd.org To: perl@FreeBSD.org Subject: [Bug 193934] New: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)" Message-ID: <bug-193934-14331@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193934 Bug ID: 193934 Summary: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)" Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Infrastructure Assignee: perl@FreeBSD.org Reporter: mandree@FreeBSD.org CC: marino@FreeBSD.org, perl@FreeBSD.org Attachment #147679 maintainer-approval?(perl@FreeBSD.org) Flags: CC: perl@FreeBSD.org Created attachment 147679 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147679&action=edit Fix bogus *** Error 1 (ignored) and reinstate error check for ${FIND}/${SED}. ports/Mk/Uses/perl5.mk abuses shell list sequencing with "&&" operators, and this causes bogus errors in make on ports that run fix-packlist without the SITE_PERL_REL/PERL_ARCH/auto dir installed, for instance, marino's upcoming net-mgmt/netdisco port. The syntax goes along these lines: -@a && b But if "a" failing isn't an error, then instead we should write: if a ; then b ; fi This will also ensure that errors from b are NOT ignored (they are now). Proposed patch attached. Please check if this needs an -exp run. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193934-14331>