Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Dec 2013 15:59:42 -0700
From:      Ian Lepore <ian@FreeBSD.org>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r259893 - head/sys/vm
Message-ID:  <1388012382.1158.128.camel@revolution.hippie.lan>
In-Reply-To: <201312252232.rBPMWZ6a042376@svn.freebsd.org>
References:  <201312252232.rBPMWZ6a042376@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2013-12-25 at 22:32 +0000, Dimitry Andric wrote:
> Author: dim
> Date: Wed Dec 25 22:32:34 2013
> New Revision: 259893
> URL: http://svnweb.freebsd.org/changeset/base/259893
> 
> Log:
>   In sys/vm/vm_pageout.c, since vm_pageout_worker() takes a void * as
>   argument, cast the incoming 0 argument to void *, to silence a warning
>   from clang 3.4 ("expression which evaluates to zero treated as a null
>   pointer constant of type 'void *' [-Wnon-literal-null-conversion]").
>   
>   MFC after:	3 days
> 
> Modified:
>   head/sys/vm/vm_pageout.c
> 
> Modified: head/sys/vm/vm_pageout.c
> ==============================================================================
> --- head/sys/vm/vm_pageout.c	Wed Dec 25 22:14:42 2013	(r259892)
> +++ head/sys/vm/vm_pageout.c	Wed Dec 25 22:32:34 2013	(r259893)
> @@ -1699,7 +1699,7 @@ vm_pageout(void)
>  		}
>  	}
>  #endif
> -	vm_pageout_worker((uintptr_t)0);
> +	vm_pageout_worker((void *)(uintptr_t)0);
>  }
>  
>  /*

Why isn't the fix for this just vm_pageout_worker(NULL); ?

-- Ian





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1388012382.1158.128.camel>