Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Apr 2014 04:35:22 GMT
From:      Jia-Shiun Li <jiashiun@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/188641: [patch] x11-drivers/xf86-video-intel is make jobs safe
Message-ID:  <201404150435.s3F4ZM7S038547@cgiserv.freebsd.org>
Resent-Message-ID: <201404150440.s3F4e1ee075447@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         188641
>Category:       ports
>Synopsis:       [patch] x11-drivers/xf86-video-intel is make jobs safe
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 15 04:40:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jia-Shiun Li
>Release:        11.0-CURRENT
>Organization:
>Environment:
FreeBSD 4cbsd 11.0-CURRENT FreeBSD 11.0-CURRENT #30 r264316: Thu Apr 10 23:46:51 CST 2014 jsli@4cbsd:/usr/obj/usr/src/sys/Minimal amd64
>Description:
x11-drivers/xf86-video-intel looks fine without MAKE_JOBS_UNSAFE


jsli@4cbsd:/mnt/xf86-video-intel # sysctl kern.smp.cpus hw.model
kern.smp.cpus: 4
hw.model: Intel(R) Core(TM) i5-3450 CPU @ 3.10GHz
jsli@4cbsd:/mnt/xf86-video-intel # time make -DBATCH MAKE_JOBS_NUMBER=64
....
--- lowlevel-blt-bench ---
  CCLD     lowlevel-blt-bench
31.230u 5.693s 0:15.53 237.7%   33847+351k 4+33io 0pf+0w
jsli@4cbsd:/mnt/xf86-video-intel # df -h /mnt
Filesystem    Size    Used   Avail Capacity  Mounted on
tmpfs         1.0G    138M    886M    14%    /mnt
jsli@4cbsd:/mnt/xf86-video-intel #
>How-To-Repeat:

>Fix:
Remove the line 'MAKE_JOBS_UNSAFE=yes'. Trivial patch is attached.

Patch attached with submission follows:

diff -bur xf86-video-intel.orig/Makefile xf86-video-intel/Makefile
--- xf86-video-intel.orig/Makefile	2014-01-23 01:00:46.000000000 +0800
+++ xf86-video-intel/Makefile	2014-04-15 12:32:29.000000000 +0800
@@ -30,7 +30,6 @@
 INTEL_REVISION=	1
 CONFIGURE_ENV+=	xorg_cv_cc_flag__Wno_maybe_uninitialized=no
 CONFIGURE_ARGS+=	--enable-sna
-MAKE_JOBS_UNSAFE=yes
 PLIST_SUB+=	OLD="@comment "
 EXTRA_PATCHES+=	${PATCHDIR}/extra-src__sna__sna_threads.c \
 		${PATCHDIR}/extra-src_sna_kgem.c \


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404150435.s3F4ZM7S038547>