Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Oct 2006 23:25:58 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 107380 for review
Message-ID:  <200610062325.k96NPwkH066800@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107380

Change 107380 by imp@imp_lighthouse on 2006/10/06 23:25:23

	Fix logic error.  Also cleanup a little on error.

Affected files ...

.. //depot/projects/arm/src/sys/dev/spibus/spibus.c#5 edit

Differences ...

==== //depot/projects/arm/src/sys/dev/spibus/spibus.c#5 (text+ko) ====

@@ -136,8 +136,10 @@
 	if (child == NULL) 
 		return (child);
 	devi = malloc(sizeof(struct spibus_ivar), M_DEVBUF, M_NOWAIT | M_ZERO);
-	if (devi != NULL)
+	if (devi == NULL) {
+		device_delete_child(dev, child);
 		return (0);
+	}
 	device_set_ivars(child, devi);
 	return (child);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610062325.k96NPwkH066800>